Skip to content

Commit

Permalink
pedr02b2 data for issue #347
Browse files Browse the repository at this point in the history
  • Loading branch information
code423n4 committed Sep 19, 2022
1 parent c40a177 commit 6825c49
Showing 1 changed file with 16 additions and 0 deletions.
16 changes: 16 additions & 0 deletions data/pedr02b2-Q.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
### No vote duration time limit

partygovernance.sol

https://github.com/PartyDAO/party-contracts-c4/blob/3896577b8f0fa16cba129dc2867aba786b730c1b/contracts/party/PartyGovernance.sol#L75

there should be some standard put into place for how long the vote duration is set ofr to stop an unreasonable time being put into place, so that a proposal can not be left stale due to unreasonable time constraints


### Can pay funds but cannot withdraw

party.sol

https://github.com/PartyDAO/party-contracts-c4/blob/3896577b8f0fa16cba129dc2867aba786b730c1b/contracts/party/Party.sol#L47

has a payable function but no withdraw or way to withdraw funds, consider adding such a function or fallback function incase the need ever arise so funds can never be locked into the contract

0 comments on commit 6825c49

Please sign in to comment.