Skip to content

Commit

Permalink
Report for issue #59 updated by RaymondFam
Browse files Browse the repository at this point in the history
  • Loading branch information
code423n4 committed Sep 19, 2022
1 parent eb807ab commit 23ce6fb
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions data/RaymondFam-Q.md
Original file line number Diff line number Diff line change
Expand Up @@ -57,3 +57,8 @@ https://github.com/PartyDAO/party-contracts-c4/blob/main/contracts/party/Party.s
`call`, which returns a boolean value indicating success or failure, in combination with re-entrancy guard is the recommended method to use after December 2019. And, guard against re-entrancy by making all state changes before calling other contracts using re-entrancy guard modifier. Here's one instance entailed:

https://github.com/PartyDAO/party-contracts-c4/blob/main/contracts/crowdfund/Crowdfund.sol#L487

## No `withdraw()` for Additional ETH Left in the Contract
The following line of code could receive ETH returned from an auction and also other sources including someone forces (suicides) ETH into the contract. The inherited functions from `Crowdfund.sol` seem to only cater for address(this).balance at the initializer for the initial contributors, and refund `ethOwed` based on unused contributions. Consider implementing a `withdraw()` just in case there will be additional ETH stuck in the contract.

https://github.com/PartyDAO/party-contracts-c4/blob/main/contracts/crowdfund/AuctionCrowdfund.sol#L144

0 comments on commit 23ce6fb

Please sign in to comment.