QA Report #698
Labels
bug
Something isn't working
QA (Quality Assurance)
Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
deadline comparison
There is
castVoteBySig
function inGovernor
contract. It accepts_deadline
as a parameter and checks it is valid comparing toblock.timestamp
. Specifically, the function performs such checks.There is another logic with non-strict comparison in different parts of the code:
Treasury.sol
Auction.sol
It is reasonable to have consistent logic in all places -- we propose to use non-strict comparison in
castVoteBySig
function.The text was updated successfully, but these errors were encountered: