Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA Report #663

Open
code423n4 opened this issue Sep 15, 2022 · 1 comment
Open

QA Report #663

code423n4 opened this issue Sep 15, 2022 · 1 comment
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax

Comments

@code423n4
Copy link
Contributor

code423n4 commented Sep 15, 2022 •
edited
Loading

  1. Missing zero address check
    he following functions are missing zero address checks which may require redeployment of contracts
    Manager.constructor()
    Auction._authorizeUpgrade()

  2. Missing zero value check
    The following functions are missing zero value checks. Setting the state variable to 0 would affect other functions in the contract, possibly causing reverts.

Auction.setDuration()
Auction.setReservePrice()
Auction.setTimeBuffer()
Auction.setMinimumBidIncrement()
@code423n4 code423n4 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Sep 15, 2022
code423n4 added a commit that referenced this issue Sep 15, 2022
@code423n4
cryptphi issue #663
e0fe7ad
code423n4 added a commit that referenced this issue Sep 15, 2022
@code423n4
cryptphi data for issue #663
ac7192b
@GalloDaSballo
Copy link
Collaborator

1L for zero-check on adress

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GalloDaSballo @code423n4