New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gas Optimizations #231

Open

code423n4 opened this issue Jun 14, 2022 · 0 comments

Labels

bug G (Gas Optimization)

Contributor

code423n4 commented Jun 14, 2022

Split require to avoid using && opcode

Details: In L129-137 of wfCashLogic.sol consider changing the code

require(
            ac.hasDebt == 0x00 &&
            assets.length == 1 &&
            EncodeDecode.encodeERC1155Id(
                assets[0].currencyId,
                assets[0].maturity,
                assets[0].assetType
            ) == fCashID
        );

to the following version without the && operator:

require(ac.hasDebt == 0x00);
require(assets.length == 1);
require(EncodeDecode.encodeERC1155Id(
          assets[0].currencyId,
          assets[0].maturity,
	        assets[0].assetType
        == fCashID));

Note: This optimization can became invalid if an error message is added to require. Furthermore, consider using custom errors to save gas.

code423n4 added bug G (Gas Optimization) labels

code423n4 added a commit that referenced this issue


          Tadashi issue #231

9c4c254

jeffywu added Notional and removed Notional labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment