Open-Shell #42
Open
Open-Shell #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed issue related to the cleanup of the accessibility COM objects that may cause Explorer to crash. Submitted by Ivo Beltchev. Fixes #53
Added link to latest nightly build
Prettified links on main page.
- Icon link - Home page link - AppVeyor status badge - Latest nightly link
* Fix naming inconsistencies 'Menu' vs 'StartMenu' * Installer: Remove Facebook link * Installer: Remove PayPal donate remnants * OpenShellReadme: Remove info about product version
One can easily find Readme shortcut in Open-Shell's start menu folder.
Copy data/settings from legacy Classic Shell if we don't have any yet.
Plus C++ standard conformance fixes.
Latest version of ClassicShell was 4.3.1. There is no reason to display any warning about very old versions (< 2.0.0). Besides, this will remove dependency on version.dll which could be misused for DLL hijacking attack. Fixes #72
There is no need for password protected beta versions.
…e a bit easier) During upgrade from ClassicShell we'll try to terminate ClassicStartMenu.exe as well. So that installer won't complain about files being in use.
* Fix ITA translation Fixed Italian translation; Updated header * Fix ITA trans
Changed links to github for Update.cpp and Update.rc.
Commit 1a5f62a added possibility to hide Lock/Sleep/Hibernate buttons if they were disabled in system power settings. Unfortunately this didn't work for Lock button. To fix the behavior we have to add lock command to `g_StdOptions` array and then all the checks introduced in 1a5f62a will apply properly. #173
`Open-Shell` needs to adjust itself after OS upgrade. It seems that `StartMenuHelper` registration is lost after such upgrade: http://www.classicshell.net/forum/viewtopic.php?f=7&t=8082#p34821 To fix this registration, administrator rights are required (means user interaction, UAC). While this is acceptable in consumer environment, it is typically not desired in business environment where users typically doesn't have administrator rights. This patch allows to run `Open-Shell` in silent upgrade mode that will: * check if OS version changed (otherwise end immediately) * perform OS upgrade tasks without any user interraction Such mode can be then used to create scheduled task that will run this silent upgrade check on every boot with system rights: `schtasks /Create /RU "NT AUTHORITY\SYSTEM" /SC ONSTART /TN "Open-Shell OS updgrade check" /TR "%ProgramFiles%\Open-Shell\StartMenu.exe -upgrade -silent"` #167
Add download button as requested by some users.
In several cases we don't want menu(s) to close when an action on menu was done. For example on drag-n-drop or menu item deletion (where confirmation dialog is shown). In such situations `s_bPreventClosing` was set to true (and then back to false when closing was allowed again). Though original code honored this variable only in certain situations and typically (at least on Win10) menus were hidden/closed despite of it. This patch changes the behavior and menus(s) are not closed when `s_bPreventClosing` is set to true. Basically now menu(s) stay visible until there is an action that changes active window. Following functionality was also removed because it is not needed now: * CMenuContainer::HideTemp * COwnerWindow::OnClear WM_CLEAR was sent to the window only by already removed `HideTemp`
…askbar` The setting was improperly named and evoked that custom button should be "moved" to the corner of screen even for center aligned taskbar on Windows 11. What the setting does (and always did) is to align button to the edge of taskbar (e.g. bottom edge in case of bottom taskbar) instead of centering it. Hopefully it will be now more clear.
It may happen that during `InitStartMenuDLL` execution some component posts a message that is then intercepted by (still active) `HookInject` that will call `InitStartMenuDLL` again (and everything will repeat). To prevent such endless recursion during initialization, we will make sure that `InitStartMenuDLL` will be executed just once.
Update the old blurry start menu previews to a more modern pixel-perfect ones that resemble the new default immersive skin.
There is no need to limit it just to Win10+ as it works well also on older Windows. #1866
It uses metro colors so it works only on Win8+. #1866 (comment)
Windows 11 22H2 introduced new touch-optimized taskbar for devices with touch screen. It seems that in this mode taskbar window size is bigger than actual taskbar on screen. There is region defined for the window that covers actually displayed portion of the window. We should account for that region (if present) when obtaining taskbar window dimensions. More info about how to enable/disable touch taskbar: https://www.elevenforum.com/t/turn-on-or-off-tablet-optimized-taskbar-in-windows-11.5133/
It seems that AllSystemSettings file name changed since 24H2. We will look for new file first and then fall-back to original one. Fixes #2033.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Want to look at the problem with missing jump list for Visual Studio and others.