Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return empty state_details for deprecated bundle types. #4229

Merged
merged 6 commits into from
Aug 24, 2022

Conversation

leilenah
Copy link
Collaborator

@leilenah leilenah commented Aug 22, 2022

Reasons for making this change

There are old worksheets that contain program bundles. This bundle type has been deprecated. However, we should not throw an internal error if an old worksheet contains this type of bundle.

This change updates the get_bundle_state_details function to return an empty string for deprecated bundle types.

Related issues

#4228
#4235

Screenshots

Checklist

  • I've added a screenshot of the changes, if this is a frontend change
  • I've added and/or updated tests, if this is a backend change
  • I've run the pre-commit.sh script
  • I've updated docs, if needed

Copy link
Collaborator

@percyliang percyliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Ideally, we would do a database migration to get rid of program so that the code can remain as simple as possible. Otherwise, this change might lead to some silent failures.

@mergify mergify bot merged commit c79edcd into master Aug 24, 2022
@mergify mergify bot deleted the fix/4228-worksheet-fetch branch August 24, 2022 22:02
@leilenah leilenah mentioned this pull request Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[USER ISSUE] Unable to fetch data for worksheet that exists in the database
2 participants