NFS-safe Dependency Manager #3861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teetone
changed the title
epicfaace
reviewed
Feb 9, 2022
| @@ -53,6 +98,9 @@ class DependencyManager(StateTransitioner, BaseDependencyManager): | |||
| # the data format of how we store this) | |||
| MAX_SERIALIZED_LEN = 60000 | |||
|
|
|||
| # If it has been this long since a worker has downloaded anything, another worker will take over downloading. | |||
There was a problem hiding this comment.
Do additional testing:
- run bundles on workers A, B, C that all share cache
- force kill worker A while it's downloading a dependency
- see how long it takes the dependency to be re-downloaded by B or C
There was a problem hiding this comment.
Did you do this yet @teetone ?
epicfaace
reviewed
Feb 14, 2022
epicfaace
reviewed
Feb 14, 2022
epicfaace
reviewed
Feb 28, 2022
| @@ -53,6 +98,9 @@ class DependencyManager(StateTransitioner, BaseDependencyManager): | |||
| # the data format of how we store this) | |||
| MAX_SERIALIZED_LEN = 60000 | |||
|
|
|||
| # If it has been this long since a worker has downloaded anything, another worker will take over downloading. | |||
There was a problem hiding this comment.
Did you do this yet @teetone ?
epicfaace
approved these changes
Mar 2, 2022
|
@teetone Let me know once this is ready to merge |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
Use flufl.lock to create an NFS-safe Dependency Manager.
Related issues
Resolves #3710
Checklist