Add endpoint to list comments #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was hard to understand the difference between createComment and createPullRequestComment The createPullRequestComment creates a comment that is not on a line (like PR summary)
pedrorijo91
approved these changes
Aug 14, 2017
mrfyda
suggested changes
Aug 14, 2017
| @@ -92,4 +94,10 @@ class PullRequestServices(client: BitbucketClient) { | |||
| client.delete(url) | |||
| } | |||
|
|
|||
| def listComments(author: String, repo: String, pullRequestId: Int): RequestResponse[Seq[SimplePullRequestComment]] = { | |||
| val url = s"https://bitbucket.org/!api/1.0/repositories/$author/$repo/pullrequests/$pullRequestId/comments" | |||
There was a problem hiding this comment.
The pagination is for v2, and unfortunately v2 no longer has the "anchor" that I need.. Even bitbucket themselves use their v1 API for comments when showing a PR online 😭
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add endpoint to list comments