Rework CMake Xcode support. #20205
Merged
Rework CMake Xcode support. #20205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
trojanfoe
commented
Oct 15, 2019
trojanfoe
commented
- Dropped the use of the cocos_pak_xcode() cmake function as it was not working correctly.
- Made it easier to specify deployment targets and other Xcode settings when generating the Xcode project.
- Add documentation to demonstrate how to use the new settings.
Mee-gu
reviewed
Oct 17, 2019
- Build using C++17 by default.
- Simplified customization of Xcode project via cmake.
- Add documentation to demonstrate how to use the customization.
- NOTE: I believe we could compile with bitcode enabled if the box2d
library was compiled using bitcode.
PatriceJiang
pushed a commit
to PatriceJiang/cocos2d-x
that referenced
this pull request
Dec 10, 2019
fix bug introduced in cocos2d#20205
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.