Revert "Remove ccglstatecache (#19013)" #19219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…os2d#19177)" This reverts commit 30daf5d.
This reverts commit 7dcee2b.
|
@drelaptop can you please elaborate more on this drastic revert? |
Contributor
|
Because it breaks compatibility, and it may bring some bugs that are not easy to found and fix, such as this one #19177. When supporting metal(may be next version), these OpenGL ES related codes will be deleted too, and that's a better time to do it. |
minggo
approved these changes
Nov 29, 2018
Contributor
|
And we found wrong effect in 3D modules too. |
|
Make sense. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this modify will comes again with multi renderer background, for at that time we didn't need to consider compatibility strictly.