fix skeleton data destroy cause a memory leak #4307
Conversation
| } | ||
| } | ||
| info->release(); |
There was a problem hiding this comment.
Why remove retain & release code ?
|
@PatriceJiang Please review this change. |
|
It seems that the memory leak is caused by the mismatch between the calls of retainByUUID and releaseByUUID. The current fix requires addressing a potential issue: releasing the SkeletonData, which is held by multiple places, prematurely leading to a crash. |
|
这个合并并不能解决内存泄漏问题 |
@Sunny-guangge How to reproduce the leak you found? |
非常简单 加载一个spine资源 然后销毁 销毁的时候 在js skeletonDataMgr.setDestroyCallback function添加断点 是不执行这段代码的 |
现在在iOS17beta系统上 必现崩溃 |
|
@Sunny-guangge ios17崩溃问题有解决方案没 |
|
@bofeng-song Please check the crash issue on ios17. |
最好不要参考之前的pr修改， |
No description provided.