Skip to content

Commit

Permalink
enable -Werror=sign-compare in our Bazel build (pytorch#98671)
Browse files Browse the repository at this point in the history
enable -Werror=sign-compare in our Bazel build

Summary:
This is already turned on for CMake, let's see what breaks.

Test Plan: Rely on CI.

Reviewers: sahanp

Subscribers:

Tasks:

Tags:

Pull Request resolved: pytorch#98671
Approved by: https://github.com/kit1980
  • Loading branch information
mikey dagitses authored and pytorchmergebot committed Apr 26, 2023
1 parent 6789342 commit fab2e39
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions .bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -69,10 +69,6 @@ build --per_file_copt='^//.*\.(cpp|cc)$'@-Werror=all
# The following warnings come from -Wall. We downgrade them from error
# to warnings here.
#
# sign-compare has a tremendous amount of violations in the
# codebase. It will be a lot of work to fix them, just disable it for
# now.
build --per_file_copt='^//.*\.(cpp|cc)$'@-Wno-sign-compare
# We intentionally use #pragma unroll, which is compiler specific.
build --per_file_copt='^//.*\.(cpp|cc)$'@-Wno-error=unknown-pragmas

Expand Down

0 comments on commit fab2e39

Please sign in to comment.