collection: adding allow-unsafe-internals flag#240
Merged
Conversation
sravotto
force-pushed
the
sr8_internals
branch
from
37e1256 to
b28647e
Compare
BramGruneir
approved these changes
Jan 15, 2026
BramGruneir
left a comment
BramGruneir
left a comment
There was a problem hiding this comment.
LGTM, but please make the suggested change for readability first.
internal/database/factory.go
Outdated
| // It waits until a connection can be established, or that the context has been cancelled. | ||
| func New(ctx context.Context, URL string) (*Pool, error) { | ||
| return new(ctx, URL, false) | ||
| return new(ctx, URL, false, false) |
There was a problem hiding this comment.
can you add after the boolean /* what this does */ so one does not need to lookup the signature.
There was a problem hiding this comment.
(for everywhere we you're just passing in a true or false
The allow-unsafe-internals is required in v26 to allow visus to run queries that use crdb_internal or system tables. Changed mainNode.sql to use [SHOW NODE_ID]
sravotto
force-pushed
the
sr8_internals
branch
from
b28647e to
c47ba24
Compare
Collaborator
Author
|
Thanks for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The allow-unsafe-internals is required in v26 to allow visus to run queries that use crdb_internal or system tables.