Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix prometheus metric export test #265

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Fix prometheus metric export test #265

merged 1 commit into from
Feb 12, 2025

Conversation

aa-joshi
Copy link
Contributor

@aa-joshi aa-joshi commented Feb 12, 2025 •
edited
Loading

Commit checklist

  • Changelog
  • Doc gen (make generate)
  • Integration test(s)
  • Acceptance test(s)
  • Example(s)

@aa-joshi aa-joshi force-pushed the fix_prometheus_metric_export_test branch from 3b558b0 to dc81edc Compare February 12, 2025 04:47
@aa-joshi aa-joshi force-pushed the fix_prometheus_metric_export_test branch from dc81edc to 3f1324a Compare February 12, 2025 05:03
@aa-joshi aa-joshi marked this pull request as ready for review February 12, 2025 05:07
aa-joshi
aa-joshi commented Feb 12, 2025
View reviewed changes
internal/provider/metric_export_prometheus_config_resource_test.go
Times(3)

// Update
s.EXPECT().GetCluster(gomock.Any(), clusterID).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We removed tf update validation as prometheus metric export integration doens't need update flow. It is either enable and disable.

aa-joshi
aa-joshi commented Feb 12, 2025
View reviewed changes
internal/provider/metric_export_prometheus_config_resource_test.go
regions = [{
name = "us-east1"
node_count: 3
node_count: 1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The node count is reduced to 1 to reduce the cost of additional node provisioning.

arjunmahishi
arjunmahishi approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@arjunmahishi arjunmahishi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aa-joshi aa-joshi merged commit c67e8c2 into cockroachdb:main Feb 12, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arjunmahishi arjunmahishi arjunmahishi approved these changes

@fantapop fantapop Awaiting requested review from fantapop

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aa-joshi @arjunmahishi