Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix get_multi_columns() to support multiple table names #221

Merged
merged 2 commits into from
Aug 31, 2023
Merged

Fix get_multi_columns() to support multiple table names #221

merged 2 commits into from
Aug 31, 2023

Conversation

gordthompson
Copy link
Collaborator

Fixes: #220

Also,
Add mypy marker to pyproject.toml
Update requirements for dev and test via make

@gordthompson
Fix get_multi_columns() to support multiple table names
ead6e34 
Fixes: cockroachdb#220

Also,
Add mypy marker to pyproject.toml
Update requirements for dev and test via make
@gordthompson gordthompson mentioned this pull request Aug 17, 2023
Closed
@gordthompson gordthompson requested a review from rafiss August 17, 2023 19:09
rafiss
rafiss approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding this!

@gordthompson gordthompson merged commit a1816f9 into cockroachdb:master Aug 31, 2023
@gordthompson gordthompson deleted the issue_220 branch August 31, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafiss rafiss rafiss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

table metadata reflection with a filtered subset of tables
2 participants
@gordthompson @rafiss