Test Issue

[medaminezghal]

>>> from alembic.testing.suite import *

AttributeError                            Traceback (most recent call last)

<ipython-input-5-fdbe023ba083> in <cell line: 0>()
----> 1 from alembic.testing.suite import *

2 frames

/usr/local/lib/python3.11/dist-packages/alembic/testing/suite/test_autogen_computed.py in AutogenerateComputedTest()
     86         lambda: (sa.Computed("bar*5"), sa.Computed("bar * 42")),
     87     )
---> 88     @config.requirements.computed_reflects_normally
     89     def test_cant_change_computed_warning(self, test_case):
     90         arg_before, arg_after = testing.resolve_lambda(test_case, **locals())

AttributeError: 'SuiteRequirements' object has no attribute 'computed_reflects_normally'

This error come from this file.

[gordthompson]

I am able to reproduce your issue

(.venv) gord@sqla-crdb:~/git/sqlalchemy-cockroachdb$ python
Python 3.9.21 (main, Dec  4 2024, 08:53:34) 
[GCC 13.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from alembic.testing.suite import *
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/gord/PycharmProjects/sqla_crdb_demo/.venv/lib/python3.9/site-packages/alembic/testing/suite/__init__.py", line 2, in <module>
    from .test_autogen_computed import *  # noqa
  File "/home/gord/PycharmProjects/sqla_crdb_demo/.venv/lib/python3.9/site-packages/alembic/testing/suite/test_autogen_computed.py", line 18, in <module>
    class AutogenerateComputedTest(AutogenFixtureTest, TestBase):
  File "/home/gord/PycharmProjects/sqla_crdb_demo/.venv/lib/python3.9/site-packages/alembic/testing/suite/test_autogen_computed.py", line 88, in AutogenerateComputedTest
    @config.requirements.computed_reflects_normally
AttributeError: 'SuiteRequirements' object has no attribute 'computed_reflects_normally'

The SQLAlchemy and Alembic test suites use a number of pytest features that expect those tests to be run from a "wrapper" function. For this dialect, those "wrappers" are

https://github.com/cockroachdb/sqlalchemy-cockroachdb/blob/master/test/test_suite_sqlalchemy.py

and

https://github.com/cockroachdb/sqlalchemy-cockroachdb/blob/master/test/test_suite_alembic.py

So if we want to run some Alembic tests we need to do something like this

(.venv) gord@sqla-crdb:~/git/sqlalchemy-cockroachdb$ pytest -k AutogenerateComputedTest test/test_suite_alembic.py
==================================================================== sqlalchemy installation =====================================================================
SQLAlchemy 2.0.38 (user site loaded)
Path: /home/gord/git/sqlalchemy-cockroachdb/.venv/lib/python3.9/site-packages/sqlalchemy/__init__.py
compiled extension enabled, e.g. /home/gord/git/sqlalchemy-cockroachdb/.venv/lib/python3.9/site-packages/sqlalchemy/cyextension/util.cpython-39-x86_64-linux-gnu.so 
====================================================================== test session starts =======================================================================
platform linux -- Python 3.9.21, pytest-8.3.4, pluggy-1.5.0 -- /home/gord/git/sqlalchemy-cockroachdb/.venv/bin/python
cachedir: .pytest_cache
rootdir: /home/gord/git/sqlalchemy-cockroachdb
configfile: pyproject.toml
collected 108 items / 96 deselected / 12 selected                                                                                                                

test/test_suite_alembic.py::AutogenerateComputedTest_cockroachdb+psycopg2_9_5_0::test_add_computed_column PASSED                                           [  8%]
test/test_suite_alembic.py::AutogenerateComputedTest_cockroachdb+psycopg2_9_5_0::test_cant_change_computed_warning[<lambda>0] PASSED                       [ 16%]
test/test_suite_alembic.py::AutogenerateComputedTest_cockroachdb+psycopg2_9_5_0::test_cant_change_computed_warning[<lambda>1] PASSED                       [ 25%]
test/test_suite_alembic.py::AutogenerateComputedTest_cockroachdb+psycopg2_9_5_0::test_cant_change_computed_warning[<lambda>2] PASSED                       [ 33%]
test/test_suite_alembic.py::AutogenerateComputedTest_cockroachdb+psycopg2_9_5_0::test_cant_change_computed_warning[<lambda>3] PASSED                       [ 41%]
test/test_suite_alembic.py::AutogenerateComputedTest_cockroachdb+psycopg2_9_5_0::test_computed_unchanged[<lambda>-_exclusions_00] PASSED                   [ 50%]
test/test_suite_alembic.py::AutogenerateComputedTest_cockroachdb+psycopg2_9_5_0::test_computed_unchanged[<lambda>-_exclusions_01] PASSED                   [ 58%]
test/test_suite_alembic.py::AutogenerateComputedTest_cockroachdb+psycopg2_9_5_0::test_computed_unchanged[<lambda>-_exclusions_02] PASSED                   [ 66%]
test/test_suite_alembic.py::AutogenerateComputedTest_cockroachdb+psycopg2_9_5_0::test_computed_unchanged[<lambda>-_exclusions_03] PASSED                   [ 75%]
test/test_suite_alembic.py::AutogenerateComputedTest_cockroachdb+psycopg2_9_5_0::test_computed_unchanged[<lambda>-_exclusions_04] SKIPPED ('test/test_...) [ 83%]
test/test_suite_alembic.py::AutogenerateComputedTest_cockroachdb+psycopg2_9_5_0::test_remove_computed_column PASSED                                        [ 91%]
test/test_suite_alembic.py::AutogenerateComputedTest_cockroachdb+psycopg2_9_5_0::test_remove_computed_default_on_computed SKIPPED ('test/test_suite_al...) [100%]

==================================================================== short test summary info =====================================================================
SKIPPED [1] .venv/lib/python3.9/site-packages/sqlalchemy/testing/config.py:419: 'test/test_suite_alembic.py::AutogenerateComputedTest_cockroachdb+psycopg2_9_5_0::test_computed_unchanged[<lambda>-_exclusions_04] (call)' : marked as skip
SKIPPED [1] .venv/lib/python3.9/site-packages/sqlalchemy/testing/config.py:419: 'test/test_suite_alembic.py::AutogenerateComputedTest_cockroachdb+psycopg2_9_5_0::test_remove_computed_default_on_computed (call)' : marked as skip
========================================================== 10 passed, 2 skipped, 96 deselected in 6.76s ==========================================================

[medaminezghal]

@gordthompson Could you try it with the same environment but with Python 3.13?
For me it didn't work.
One other thing I found a difference between our output.
1- it just test the test/test_introspection.py and they're all failed.
2- In the test environment, This doesn't appear to me even though I use the same SQLAlchemy version that you use:

==================================================================== sqlalchemy installation =====================================================================
SQLAlchemy 2.0.38 (user site loaded)
Path: /home/gord/git/sqlalchemy-cockroachdb/.venv/lib/python3.9/site-packages/sqlalchemy/__init__.py
compiled extension enabled, e.g. /home/gord/git/sqlalchemy-cockroachdb/.venv/lib/python3.9/site-packages/sqlalchemy/cyextension/util.cpython-39-x86_64-linux-gnu.so

[gordthompson]

Could you try it with the same environment but with Python 3.13?

Yes, it also works with Python 3.13

(.venv) gord@sqla-crdb:~/git/sqlalchemy-cockroachdb$ pytest test/test_introspection.py
======================================================================== sqlalchemy installation =========================================================================
SQLAlchemy 2.0.38 (user site loaded)
Path: /home/gord/git/sqlalchemy-cockroachdb/.venv/lib/python3.13/site-packages/sqlalchemy/__init__.py
compiled extension enabled, e.g. /home/gord/git/sqlalchemy-cockroachdb/.venv/lib/python3.13/site-packages/sqlalchemy/cyextension/util.cpython-313-x86_64-linux-gnu.so 
========================================================================== test session starts ===========================================================================
platform linux -- Python 3.13.2, pytest-8.3.4, pluggy-1.5.0 -- /home/gord/git/sqlalchemy-cockroachdb/.venv/bin/python
cachedir: .pytest_cache
rootdir: /home/gord/git/sqlalchemy-cockroachdb
configfile: pyproject.toml
collected 16 items                                                                                                                                                       

test/test_introspection.py::IntrospectionTest::test_create_metadata PASSED                                                                                         [  6%]
test/test_introspection.py::TestTypeReflection::test_array PASSED                                                                                                  [ 12%]
test/test_introspection.py::TestTypeReflection::test_blob PASSED                                                                                                   [ 18%]
test/test_introspection.py::TestTypeReflection::test_boolean PASSED                                                                                                [ 25%]
test/test_introspection.py::TestTypeReflection::test_date PASSED                                                                                                   [ 31%]
test/test_introspection.py::TestTypeReflection::test_decimal PASSED                                                                                                [ 37%]
test/test_introspection.py::TestTypeReflection::test_float PASSED                                                                                                  [ 43%]
test/test_introspection.py::TestTypeReflection::test_inet PASSED                                                                                                   [ 50%]
test/test_introspection.py::TestTypeReflection::test_int PASSED                                                                                                    [ 56%]
test/test_introspection.py::TestTypeReflection::test_interval PASSED                                                                                               [ 62%]
test/test_introspection.py::TestTypeReflection::test_json PASSED                                                                                                   [ 68%]
test/test_introspection.py::TestTypeReflection::test_time PASSED                                                                                                   [ 75%]
test/test_introspection.py::TestTypeReflection::test_timestamp PASSED                                                                                              [ 81%]
test/test_introspection.py::TestTypeReflection::test_uuid PASSED                                                                                                   [ 87%]
test/test_introspection.py::TestTypeReflection::test_varchar PASSED                                                                                                [ 93%]
test/test_introspection.py::UnknownTypeTest::test_unknown_type PASSED                                                                                              [100%]

========================================================================== 16 passed in 27.35s ===========================================================================

Note that I am running the tests from the sqlalchemy-cockroachdb source root as would be created with

$ git clone https://github.com/cockroachdb/sqlalchemy-cockroachdb.git

(.venv) gord@sqla-crdb:~/git/sqlalchemy-cockroachdb$ ls
CHANGES.md           dev-requirements.txt  pyproject.toml     README.psycopg.md         setup.cfg               sqlalchemy_cockroachdb.egg-info  test-requirements.txt
cockroachdb          LICENSE               README.asyncpg.md  README.read_committed.md  setup.py                test                             tox.ini
dev-requirements.in  Makefile              README.md          README.testing.md         sqlalchemy_cockroachdb  test-requirements.in

[medaminezghal]

@gordthompson I’m using source from git with latest version 2.0.2 but without using tox.
This commands that I use for build and test:

$ python -m build --wheel --no-isolation
$ python -m venv --system-site-packages test-env
$ test-env/bin/python -m installer dist/*.whl
$ test-env/bin/python -m pytest test

[gordthompson]

Try just running the tests from the sqlalchemy-cockroachdb source. This works for me:

gord@sqla-crdb:~$ mkdir issue_264
gord@sqla-crdb:~$ cd issue_264
gord@sqla-crdb:~/issue_264$ git clone https://github.com/cockroachdb/sqlalchemy-cockroachdb.git
Cloning into 'sqlalchemy-cockroachdb'...
remote: Enumerating objects: 1442, done.
remote: Counting objects: 100% (399/399), done.
remote: Compressing objects: 100% (169/169), done.
remote: Total 1442 (delta 305), reused 230 (delta 230), pack-reused 1043 (from 2)
Receiving objects: 100% (1442/1442), 375.16 KiB | 914.00 KiB/s, done.
Resolving deltas: 100% (861/861), done.
gord@sqla-crdb:~/issue_264$ cd sqlalchemy-cockroachdb/
gord@sqla-crdb:~/issue_264/sqlalchemy-cockroachdb$ python3 -m venv test-env
gord@sqla-crdb:~/issue_264/sqlalchemy-cockroachdb$ . test-env/bin/activate
(test-env) gord@sqla-crdb:~/issue_264/sqlalchemy-cockroachdb$ pip install --upgrade pip
Requirement already satisfied: pip in ./test-env/lib/python3.12/site-packages (24.0)
Collecting pip
  Downloading pip-25.0.1-py3-none-any.whl.metadata (3.7 kB)
Downloading pip-25.0.1-py3-none-any.whl (1.8 MB)
   ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 1.8/1.8 MB 2.1 MB/s eta 0:00:00
Installing collected packages: pip
  Attempting uninstall: pip
    Found existing installation: pip 24.0
    Uninstalling pip-24.0:
      Successfully uninstalled pip-24.0
Successfully installed pip-25.0.1
(test-env) gord@sqla-crdb:~/issue_264/sqlalchemy-cockroachdb$ pip install sqlalchemy alembic psycopg2-binary pytest
Collecting sqlalchemy
  Downloading SQLAlchemy-2.0.38-cp312-cp312-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata (9.6 kB)
Collecting alembic
  Using cached alembic-1.14.1-py3-none-any.whl.metadata (7.4 kB)
Collecting psycopg2-binary
  Downloading psycopg2_binary-2.9.10-cp312-cp312-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata (4.9 kB)
Collecting pytest
  Using cached pytest-8.3.4-py3-none-any.whl.metadata (7.5 kB)
Collecting greenlet!=0.4.17 (from sqlalchemy)
  Downloading greenlet-3.1.1-cp312-cp312-manylinux_2_24_x86_64.manylinux_2_28_x86_64.whl.metadata (3.8 kB)
Collecting typing-extensions>=4.6.0 (from sqlalchemy)
  Downloading typing_extensions-4.12.2-py3-none-any.whl.metadata (3.0 kB)
Collecting Mako (from alembic)
  Using cached Mako-1.3.9-py3-none-any.whl.metadata (2.9 kB)
Collecting iniconfig (from pytest)
  Using cached iniconfig-2.0.0-py3-none-any.whl.metadata (2.6 kB)
Collecting packaging (from pytest)
  Using cached packaging-24.2-py3-none-any.whl.metadata (3.2 kB)
Collecting pluggy<2,>=1.5 (from pytest)
  Using cached pluggy-1.5.0-py3-none-any.whl.metadata (4.8 kB)
Collecting MarkupSafe>=0.9.2 (from Mako->alembic)
  Downloading MarkupSafe-3.0.2-cp312-cp312-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata (4.0 kB)
Downloading SQLAlchemy-2.0.38-cp312-cp312-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (3.3 MB)
   ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 3.3/3.3 MB 2.0 MB/s eta 0:00:00
Using cached alembic-1.14.1-py3-none-any.whl (233 kB)
Downloading psycopg2_binary-2.9.10-cp312-cp312-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (3.0 MB)
   ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 3.0/3.0 MB 2.0 MB/s eta 0:00:00
Using cached pytest-8.3.4-py3-none-any.whl (343 kB)
Downloading greenlet-3.1.1-cp312-cp312-manylinux_2_24_x86_64.manylinux_2_28_x86_64.whl (613 kB)
   ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 613.1/613.1 kB 1.9 MB/s eta 0:00:00
Using cached pluggy-1.5.0-py3-none-any.whl (20 kB)
Downloading typing_extensions-4.12.2-py3-none-any.whl (37 kB)
Using cached iniconfig-2.0.0-py3-none-any.whl (5.9 kB)
Using cached Mako-1.3.9-py3-none-any.whl (78 kB)
Using cached packaging-24.2-py3-none-any.whl (65 kB)
Downloading MarkupSafe-3.0.2-cp312-cp312-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (23 kB)
Installing collected packages: typing-extensions, psycopg2-binary, pluggy, packaging, MarkupSafe, iniconfig, greenlet, sqlalchemy, pytest, Mako, alembic
Successfully installed Mako-1.3.9 MarkupSafe-3.0.2 alembic-1.14.1 greenlet-3.1.1 iniconfig-2.0.0 packaging-24.2 pluggy-1.5.0 psycopg2-binary-2.9.10 pytest-8.3.4 sqlalchemy-2.0.38 typing-extensions-4.12.2
(test-env) gord@sqla-crdb:~/issue_264/sqlalchemy-cockroachdb$ pytest -k AutogenerateComputedTest test/test_suite_alembic.py
===================================================== sqlalchemy installation ======================================================
SQLAlchemy 2.0.38 (user site loaded)
Path: /home/gord/issue_264/sqlalchemy-cockroachdb/test-env/lib/python3.12/site-packages/sqlalchemy/__init__.py
compiled extension enabled, e.g. /home/gord/issue_264/sqlalchemy-cockroachdb/test-env/lib/python3.12/site-packages/sqlalchemy/cyextension/util.cpython-312-x86_64-linux-gnu.so 
======================================================= test session starts ========================================================
platform linux -- Python 3.12.3, pytest-8.3.4, pluggy-1.5.0 -- /home/gord/issue_264/sqlalchemy-cockroachdb/test-env/bin/python3
cachedir: .pytest_cache
rootdir: /home/gord/issue_264/sqlalchemy-cockroachdb
configfile: pyproject.toml
collected 108 items / 96 deselected / 12 selected                                                                                  

test/test_suite_alembic.py::AutogenerateComputedTest_cockroachdb+psycopg2_9_5_0::test_add_computed_column PASSED             [  8%]
test/test_suite_alembic.py::AutogenerateComputedTest_cockroachdb+psycopg2_9_5_0::test_cant_change_computed_warning[<lambda>0] PASSED [ 16%]
test/test_suite_alembic.py::AutogenerateComputedTest_cockroachdb+psycopg2_9_5_0::test_cant_change_computed_warning[<lambda>1] PASSED [ 25%]
test/test_suite_alembic.py::AutogenerateComputedTest_cockroachdb+psycopg2_9_5_0::test_cant_change_computed_warning[<lambda>2] PASSED [ 33%]
test/test_suite_alembic.py::AutogenerateComputedTest_cockroachdb+psycopg2_9_5_0::test_cant_change_computed_warning[<lambda>3] PASSED [ 41%]
test/test_suite_alembic.py::AutogenerateComputedTest_cockroachdb+psycopg2_9_5_0::test_computed_unchanged[<lambda>-_exclusions_00] PASSED [ 50%]
test/test_suite_alembic.py::AutogenerateComputedTest_cockroachdb+psycopg2_9_5_0::test_computed_unchanged[<lambda>-_exclusions_01] PASSED [ 58%]
test/test_suite_alembic.py::AutogenerateComputedTest_cockroachdb+psycopg2_9_5_0::test_computed_unchanged[<lambda>-_exclusions_02] PASSED [ 66%]
test/test_suite_alembic.py::AutogenerateComputedTest_cockroachdb+psycopg2_9_5_0::test_computed_unchanged[<lambda>-_exclusions_03] PASSED [ 75%]
test/test_suite_alembic.py::AutogenerateComputedTest_cockroachdb+psycopg2_9_5_0::test_computed_unchanged[<lambda>-_exclusions_04] SKIPPED [ 83%]
test/test_suite_alembic.py::AutogenerateComputedTest_cockroachdb+psycopg2_9_5_0::test_remove_computed_column PASSED          [ 91%]
test/test_suite_alembic.py::AutogenerateComputedTest_cockroachdb+psycopg2_9_5_0::test_remove_computed_default_on_computed SKIPPED [100%]

===================================================== short test summary info ======================================================
SKIPPED [1] test-env/lib/python3.12/site-packages/sqlalchemy/testing/config.py:419: 'test/test_suite_alembic.py::AutogenerateComputedTest_cockroachdb+psycopg2_9_5_0::test_computed_unchanged[<lambda>-_exclusions_04] (call)' : marked as skip
SKIPPED [1] test-env/lib/python3.12/site-packages/sqlalchemy/testing/config.py:419: 'test/test_suite_alembic.py::AutogenerateComputedTest_cockroachdb+psycopg2_9_5_0::test_remove_computed_default_on_computed (call)' : marked as skip
=========================================== 10 passed, 2 skipped, 96 deselected in 7.30s ===========================================