cockroach-go1.23.12: runtime: add CurrentP #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a simple function that returns the index of the P the goroutine is running on. This will be used for efficient sharding of data structures.
RaduBerinde
changed the title
|
TFTR! |
|
@rickystewart - could we bump the patched go commit on |
RaduBerinde
added a commit
to RaduBerinde/crlib
that referenced
this pull request
Sep 29, 2025
Add support for sharding with CPU locality and add sharded counters. See counters_test.go for benchmark results. Sharding has a better implementation which can be used with the CRDB Go runtime 9 (specifically cockroachdb/go#6); this implementation is used with the `cockroach_go` build tag.
RaduBerinde
added a commit
to RaduBerinde/crlib
that referenced
this pull request
Sep 29, 2025
Add support for sharding with CPU locality and add sharded counters. See counters_test.go for benchmark results. Sharding has a better implementation which can be used with the CRDB Go runtime 9 (specifically cockroachdb/go#6); this implementation is used with the `cockroach_go` build tag.
RaduBerinde
added a commit
to RaduBerinde/crlib
that referenced
this pull request
Sep 29, 2025
Add support for sharding with CPU locality and add sharded counters. See counters_test.go for benchmark results. Sharding has two implementations, one is be used with the CRDB Go runtime (specifically cockroachdb/go#6) and the `cockroach_go` build tag.
RaduBerinde
added a commit
to RaduBerinde/crlib
that referenced
this pull request
Sep 29, 2025
Add support for sharding with CPU locality and add sharded counters. See counters_test.go for benchmark results. Sharding has two implementations, one is be used with the CRDB Go runtime (specifically cockroachdb/go#6) and the `cockroach_go` build tag. We also add a script that can be used to easily run tests against the CRDB Go (along with a CI job).
RaduBerinde
added a commit
to RaduBerinde/crlib
that referenced
this pull request
Sep 29, 2025
Add support for sharding with CPU locality and add sharded counters. See counters_test.go for benchmark results. Sharding has two implementations, one is be used with the CRDB Go runtime (specifically cockroachdb/go#6) and the `cockroach_go` build tag. We also add a script that can be used to easily run tests against the CRDB Go (along with a CI job).
RaduBerinde
added a commit
to RaduBerinde/crlib
that referenced
this pull request
Sep 30, 2025
Add support for sharding with CPU locality and add sharded counters. See counters_test.go for benchmark results. Sharding has two implementations, one is be used with the CRDB Go runtime (specifically cockroachdb/go#6) and the `cockroach_go` build tag. We also add a script that can be used to easily run tests against the CRDB Go (along with a CI job).
RaduBerinde
added a commit
to RaduBerinde/crlib
that referenced
this pull request
Sep 30, 2025
Add support for sharding with CPU locality and add sharded counters. See counters_test.go for benchmark results. Sharding has two implementations, one is be used with the CRDB Go runtime (specifically cockroachdb/go#6) and the `cockroach_go` build tag. We also add a script that can be used to easily run tests against the CRDB Go (along with a CI job).
RaduBerinde
added a commit
to RaduBerinde/crlib
that referenced
this pull request
Sep 30, 2025
Add support for sharding with CPU locality and add sharded counters. See counters_test.go for benchmark results. Sharding has two implementations, one is be used with the CRDB Go runtime (specifically cockroachdb/go#6) and the `cockroach_go` build tag. We also add a script that can be used to easily run tests against the CRDB Go (along with a CI job).
RaduBerinde
added a commit
to RaduBerinde/crlib
that referenced
this pull request
Sep 30, 2025
Add support for sharding with CPU locality and add sharded counters. See counters_test.go for benchmark results. Sharding has two implementations, one is be used with the CRDB Go runtime (specifically cockroachdb/go#6) and the `cockroach_go` build tag. We also add a script that can be used to easily run tests against the CRDB Go (along with a CI job).
RaduBerinde
added a commit
to RaduBerinde/crlib
that referenced
this pull request
Sep 30, 2025
Add support for sharding with CPU locality and add sharded counters. See counters_test.go for benchmark results. Sharding has two implementations, one is be used with the CRDB Go runtime (specifically cockroachdb/go#6) and the `cockroach_go` build tag. We also add a script that can be used to easily run tests against the CRDB Go (along with a CI job).
RaduBerinde
added a commit
to cockroachdb/crlib
that referenced
this pull request
Sep 30, 2025
Add support for sharding with CPU locality and add sharded counters. See counters_test.go for benchmark results. Sharding has two implementations, one is be used with the CRDB Go runtime (specifically cockroachdb/go#6) and the `cockroach_go` build tag. We also add a script that can be used to easily run tests against the CRDB Go (along with a CI job).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a simple function that returns the index of the P the goroutine is running on.
This will be used for efficient sharding of data structures.
Inspired from tailscale#109