queue: make queue pools safer #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The automatic sharing of queue pools, together with the queue API returning `*T` pointers can lead to code inadvertently or maliciously reading from/writing into the values from another queue (even from a separate package, if the type T is exported). We remove the singleton map and require the caller to pass a pool.
|
CC @ajwerner |
ajwerner
reviewed
Jun 6, 2024
There was a problem hiding this comment.
Fair enough. This is probably better anyway from a performance perspective. The other alternative is to unexport the Queue structure.
Reviewable status: 0 of 3 files reviewed, all discussions resolved
|
Thanks. Yeah I might still unexport it (I was planning to look around in Pebble to see if any code would benefit from it). The automatic singleton map is not very useful anyway if it's only used internally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The automatic sharing of queue pools, together with the queue API returning
*Tpointers can lead to code inadvertently or maliciously reading from/writing into the values from another queue (even from a separate package, if the type T is exported).We remove the singleton map and require the caller to pass a pool.
This change is