-
Notifications
You must be signed in to change notification settings - Fork 469
Add transaction retry info to production checklist #5797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @jseldess and @rmloveland)
v19.1/recommended-production-settings.md, line 519 at r1 (raw file):
## Transaction Retries When several transactions [are trying to modify the same underlying data concurrently](performance-best-practices-overview.html#understanding-and-avoiding-transaction-contention), all but one will fail. To avoid failures in production, your application should be engineered to handle [transaction retries](transactions.html#transaction-retries) using [client-side retry handling](transactions.html#client-side-intervention).
Is "all but one will fail" too extreme? Don't we retry automatically in a lot of cases but want client-side retry logic for the cases where we don't?
25598b1
to
2e72b07
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @jseldess)
v19.1/recommended-production-settings.md, line 519 at r1 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
Is "all but one will fail" too extreme? Don't we retry automatically in a lot of cases but want client-side retry logic for the cases where we don't?
You're right! I got some tunnel vision trying to re-use the language in the original issue that was filed.
Updated to be more nuanced and, I think, correct this time. PTAL.
@jseldess are you OK with these edits? |
Yes, LGTM now, Rich. Thank you! |
Thanks Jesse! |
Fixes #3266.