Skip to content

Add transaction retry info to production checklist #5797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2019

Conversation

rmloveland
Copy link
Contributor

Fixes #3266.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rmloveland rmloveland requested a review from jseldess November 6, 2019 17:13
Copy link
Contributor

@jseldess jseldess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @jseldess and @rmloveland)


v19.1/recommended-production-settings.md, line 519 at r1 (raw file):

## Transaction Retries

When several transactions [are trying to modify the same underlying data concurrently](performance-best-practices-overview.html#understanding-and-avoiding-transaction-contention), all but one will fail. To avoid failures in production, your application should be engineered to handle [transaction retries](transactions.html#transaction-retries) using [client-side retry handling](transactions.html#client-side-intervention).

Is "all but one will fail" too extreme? Don't we retry automatically in a lot of cases but want client-side retry logic for the cases where we don't?

@rmloveland rmloveland force-pushed the 20191106-txn-retries-production-checklist branch from 25598b1 to 2e72b07 Compare November 6, 2019 19:21
Copy link
Contributor Author

@rmloveland rmloveland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @jseldess)


v19.1/recommended-production-settings.md, line 519 at r1 (raw file):

Previously, jseldess (Jesse Seldess) wrote…

Is "all but one will fail" too extreme? Don't we retry automatically in a lot of cases but want client-side retry logic for the cases where we don't?

You're right! I got some tunnel vision trying to re-use the language in the original issue that was filed.

Updated to be more nuanced and, I think, correct this time. PTAL.

@rmloveland
Copy link
Contributor Author

@jseldess are you OK with these edits?

@jseldess
Copy link
Contributor

Yes, LGTM now, Rich. Thank you!

@rmloveland
Copy link
Contributor Author

Thanks Jesse!

@rmloveland rmloveland merged commit 76ec708 into master Nov 14, 2019
@rmloveland rmloveland deleted the 20191106-txn-retries-production-checklist branch November 14, 2019 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mention tx retries in Production Checklist
3 participants