-
Notifications
You must be signed in to change notification settings - Fork 469
Multi-use CTE's #5485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-use CTE's #5485
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stuff related to multi-use CTEs in the second commit , looks like there might have been an extra commit from lauren that got picked up in this PR?
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @justinj)
d5c1a0d
to
a660cc4
Compare
Yeah that was weird... fixed it. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but in your PR description, you mentioned factoring in MovR, which I don't see. Is something missing?
Reviewable status:
complete! 1 of 0 LGTMs obtained (and 1 stale) (waiting on @ericharmeling, @jseldess, and @rmloveland)
v19.2/known-limitations.md, line 205 at r1 (raw file):
### Referring to a CTE by name more than once {% include {{ page.version.version }}/known-limitations/cte-by-name.md %}
Can you also delete the include file itself (from _includes/v19.2/known-limitations
, since we're no longer using it?
a660cc4
to
f7581ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you look at the full diff, I updated the examples in common-table-expressions.md
to use MovR.
Reviewable status:
complete! 1 of 0 LGTMs obtained (and 1 stale) (waiting on @jseldess and @rmloveland)
v19.2/known-limitations.md, line 205 at r1 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
Can you also delete the include file itself (from
_includes/v19.2/known-limitations
, since we're no longer using it?
Done.
- Changed all CTE examples to use MovR - Added multiple-use example - Removed all lifted limitations (from common-table-expressions.md and known-limitations.md)
f7581ae
to
88899c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jseldess I added quick set-up instructions. Should be good to go now.
Reviewable status:
complete! 0 of 0 LGTMs obtained (and 2 stale) (waiting on @jseldess and @rmloveland)
Fixes #5189.
PR includes the following:
common-table-expressions.md
andknown-limitations.md
)