Skip to content

Multi-use CTE's #5485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2019
Merged

Multi-use CTE's #5485

merged 1 commit into from
Oct 2, 2019

Conversation

ericharmeling
Copy link
Contributor

Fixes #5189.

PR includes the following:

  • Changed all CTE examples to use MovR
  • Added multiple-use example
  • Removed all mentions of now-lifted limitations (from common-table-expressions.md and known-limitations.md)

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@justinj justinj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stuff related to multi-use CTEs in the second commit :lgtm:, looks like there might have been an extra commit from lauren that got picked up in this PR?

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @justinj)

@ericharmeling
Copy link
Contributor Author

ericharmeling commented Sep 25, 2019

stuff related to multi-use CTEs in the second commit :lgtm:, looks like there might have been an extra commit from lauren that got picked up in this PR?

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @justinj)

Yeah that was weird... fixed it. Thanks!

@cockroach-teamcity
Copy link
Member

@ericharmeling ericharmeling requested review from jseldess and rmloveland and removed request for rmloveland October 1, 2019 19:40
Copy link
Contributor

@jseldess jseldess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: but in your PR description, you mentioned factoring in MovR, which I don't see. Is something missing?

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (and 1 stale) (waiting on @ericharmeling, @jseldess, and @rmloveland)


v19.2/known-limitations.md, line 205 at r1 (raw file):

### Referring to a CTE by name more than once

{% include {{ page.version.version }}/known-limitations/cte-by-name.md %}

Can you also delete the include file itself (from _includes/v19.2/known-limitations, since we're no longer using it?

Copy link
Contributor Author

@ericharmeling ericharmeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you look at the full diff, I updated the examples in common-table-expressions.md to use MovR.

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (and 1 stale) (waiting on @jseldess and @rmloveland)


v19.2/known-limitations.md, line 205 at r1 (raw file):

Previously, jseldess (Jesse Seldess) wrote…

Can you also delete the include file itself (from _includes/v19.2/known-limitations, since we're no longer using it?

Done.

@cockroach-teamcity
Copy link
Member

- Changed all CTE examples to use MovR
- Added multiple-use example
- Removed all lifted limitations (from common-table-expressions.md and known-limitations.md)
Copy link
Contributor Author

@ericharmeling ericharmeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jseldess I added quick set-up instructions. Should be good to go now.

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (and 2 stale) (waiting on @jseldess and @rmloveland)

@cockroach-teamcity
Copy link
Member

@ericharmeling ericharmeling merged commit 15cd13e into master Oct 2, 2019
@ericharmeling ericharmeling deleted the multiple-cte branch October 2, 2019 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

opt: add WITH operator
4 participants