Skip to content

Conversation

RaduBerinde
Copy link
Member

@RaduBerinde RaduBerinde commented Sep 11, 2025

Add a Percent function which prints a percentage and automatically
decides to use 0 or 1 decimal digits.


This change is Reviewable

@RaduBerinde RaduBerinde requested a review from jbowens September 11, 2025 23:14
Add a `Percent` function which prints a percentage and automatically
decides to use 0 or 1 decimal digits.
@RaduBerinde RaduBerinde changed the title crhumanize: add CompactFloat crhumanize: add Percent Sep 13, 2025
@RaduBerinde
Copy link
Member Author

Changed to a more useful Percent() function.

@RaduBerinde RaduBerinde requested a review from annrpom September 16, 2025 15:00
Copy link

@annrpom annrpom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: nice

@annrpom reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jbowens)

@RaduBerinde
Copy link
Member Author

TFTR!

@RaduBerinde RaduBerinde merged commit 1094cb3 into cockroachdb:main Sep 16, 2025
7 checks passed
@RaduBerinde RaduBerinde deleted the compact-float branch September 16, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants