Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-22.2: sqlliveness: revert add timeouts to heartbeats #90271

Merged
merged 1 commit into from
Oct 21, 2022
Merged

release-22.2: sqlliveness: revert add timeouts to heartbeats #90271

merged 1 commit into from
Oct 21, 2022

Conversation

aadityasondhi
Copy link
Collaborator

@aadityasondhi aadityasondhi commented Oct 19, 2022 •
edited
Loading

This reverts commit 2ff878e.

Informs #90262

The original patch introduced a bug where the sqlliveness heartbeat
would silently exit on timeouts.

Release note (bug fix): A bug introduced in 22.1.9 that caused nodes to
refuse to run jobs under rare circumstances was fixed.

Release justification: fixing an important bug

/cc https://github.com/orgs/cockroachdb/teams/release

@aadityasondhi aadityasondhi requested a review from a team as a code owner October 19, 2022 19:09
@blathers-crl
Copy link

blathers-crl bot commented Oct 19, 2022 •
edited by aadityasondhi
Loading

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@aadityasondhi aadityasondhi removed the request for review from a team October 19, 2022 19:09
andreimatei
andreimatei approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@andreimatei andreimatei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@aadityasondhi aadityasondhi force-pushed the aadityas/revert-timeouts-sqlliveness-22.2 branch 2 times, most recently from d0cb9dd to e0b05fb Compare October 20, 2022 18:12
@aadityasondhi
release-22.2: sqlliveness: revert add timeouts to heartbeats
a7d1504 
This reverts commit 2ff878e.

Informs cockroachdb#90262

The original patch introduced a bug where the sqlliveness heartbeat
would silentlty exit on timeouts.

Release note (bug fix): A bug introduced in 22.1.9 that caused nodes to
refuse to run jobs under rare circumstances was fixed.

Release justification: fixing an important bug
@aadityasondhi aadityasondhi force-pushed the aadityas/revert-timeouts-sqlliveness-22.2 branch from e0b05fb to a7d1504 Compare October 20, 2022 18:16
@aadityasondhi aadityasondhi merged commit 6cdd1f1 into cockroachdb:release-22.2 Oct 21, 2022
@aadityasondhi aadityasondhi deleted the aadityas/revert-timeouts-sqlliveness-22.2 branch October 21, 2022 17:48
@blathers-crl blathers-crl bot mentioned this pull request Oct 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreimatei andreimatei andreimatei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aadityasondhi @cockroach-teamcity @andreimatei