Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-22.2: sql,server: increase severity of upgraded-related logging #90201

Merged
merged 1 commit into from
Oct 19, 2022
Merged

release-22.2: sql,server: increase severity of upgraded-related logging #90201

merged 1 commit into from
Oct 19, 2022

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Oct 18, 2022 •
edited by knz
Loading

Backport 1/1 commits from #90165 on behalf of @knz.

/cc @cockroachdb/release

Informs #90148.

This increases the severity from INFO in the following cases:

  • in the case when SET CLUSTER SETTING version is issued from a SQL client (WARNING in case of failure).
  • in the case when the server spontaneously decides to upgrade in the background (ERROR in case of failure).

Release note: None

Release justification: improves troubleshootability

@knz
sql,server: increase severity of upgraded-related logging
61dfcc1 
This increases the severity from INFO in the following cases:

- in the case when `SET CLUSTER SETTING version` is issued from a SQL
  client (WARNING in case of failure).
- in the case when the server spontaneously decides to upgrade
  in the background (ERROR in case of failure).

Release note: None
@blathers-crl blathers-crl bot requested a review from a team October 18, 2022 22:01
@blathers-crl blathers-crl bot requested a review from a team as a code owner October 18, 2022 22:01
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.2-90165 branch from 194628f to 61dfcc1 Compare October 18, 2022 22:01
@blathers-crl
Copy link
Author

blathers-crl bot commented Oct 18, 2022 •
edited by knz
Loading

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot requested review from ajwerner and dt October 18, 2022 22:01
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Oct 18, 2022
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@knz knz merged commit ad0b68d into release-22.2 Oct 19, 2022
@knz knz deleted the blathers/backport-release-22.2-90165 branch October 19, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dt dt dt approved these changes

@ajwerner ajwerner Awaiting requested review from ajwerner

Assignees

@knz knz

Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cockroach-teamcity @dt @knz