Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-22.2: util/log: separate kv distribution log channel in tests #89259

Merged
merged 1 commit into from
Oct 20, 2022
Merged

release-22.2: util/log: separate kv distribution log channel in tests #89259

merged 1 commit into from
Oct 20, 2022

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Oct 4, 2022 •
edited by AlexTalks
Loading

Backport 1/1 commits from #89041 on behalf of @AlexTalks.

/cc @cockroachdb/release

While the KV_DISTRIBUTION log channel was introduced recently, it was not separated out into a separate file in the test logging config like it was in the default production logging config. This change rectifies that, placing the KV_DISTRIBUTION log channel into a separate file, while retaining the messages at level WARNING or above in the main log file.

Fixes #87452.

Release note: None

Release justification: Test-only change

@blathers-crl blathers-crl bot requested a review from a team October 4, 2022 01:16
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.2-89041 branch from ea8161a to ebbea29 Compare October 4, 2022 01:16
@blathers-crl
Copy link
Author

blathers-crl bot commented Oct 4, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Oct 4, 2022
@cockroach-teamcity
Copy link
Member

This change is Reviewable

lidorcarmel
lidorcarmel approved these changes Oct 6, 2022
View reviewed changes
Copy link
Contributor

@lidorcarmel lidorcarmel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @AlexTalks)

@AlexTalks
util/log: separate kv distribution log channel in tests
2a8f2e2 
While the `KV_DISTRIBUTION` log channel was introduced recently, it was
not separated out into a separate file in the test logging config like
it was in the default production logging config. This change rectifies
that, placing the `KV_DISTRIBUTION` log channel into a separate file,
while retaining the messages at level `WARNING` or above in the main log
file.

Fixes #87452.

Release note: None
@AlexTalks AlexTalks force-pushed the blathers/backport-release-22.2-89041 branch from ebbea29 to 2a8f2e2 Compare October 20, 2022 03:22
@AlexTalks AlexTalks merged commit 59bbe40 into release-22.2 Oct 20, 2022
@AlexTalks AlexTalks deleted the blathers/backport-release-22.2-89041 branch October 20, 2022 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidorcarmel lidorcarmel lidorcarmel approved these changes

Assignees

@AlexTalks AlexTalks

Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cockroach-teamcity @lidorcarmel @AlexTalks