Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.1: spanconfig: reset job run_stats to avoid job system backoff #82858

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Jun 13, 2022

Backport 1/1 commits from #82724 on behalf of @stevendanna.

/cc @cockroachdb/release


If the coordinator of the span configuration job dies, another node
will adopt the job. However, when doing so it will bump the num_runs
run stat. As this number increases, the job system will delay future
resumptions of this job.

We solve this here by resetting the job's run_stats at the beginning
of the job.

We've yet again handled this in the job directly rather than adjusting
the behavior of the job system. In this case, my justification is that
this solution is fit for backporting.

Fixes #82689

Release note (bug fix): Fix a bug where the startup of an internal
component after a server restart could result in the delayed
application of zone configuration.


Release justification: high impact bug fix that prevents the spanconfig job from being paused for long periods of time, resulting in no reconciliation

If the coordinator of the span configuration job dies, another node
will adopt the job. However, when doing so it will bump the num_runs
run stat. As this number increases, the job system will delay future
resumptions of this job.

We solve this here by resetting the job's run_stats at the beginning
of the job.

We've yet again handled this in the job directly rather than adjusting
the behavior of the job system. In this case, my justification is that
this solution is fit for backporting.

Fixes #82689

Release note (bug fix): Fix a bug where the startup of an internal
component after a server restart could result in the delayed
application of zone configuration.
@blathers-crl blathers-crl bot requested a review from a team as a code owner June 13, 2022 22:10
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.1-82724 branch from 029ef81 to b82de97 Compare June 13, 2022 22:10
@blathers-crl
Copy link
Author

blathers-crl bot commented Jun 13, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Jun 13, 2022
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@adityamaru
Copy link
Contributor

Merging on behalf of @stevendanna

@adityamaru adityamaru merged commit 57dcb36 into release-22.1 Jun 14, 2022
@adityamaru adityamaru deleted the blathers/backport-release-22.1-82724 branch June 14, 2022 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants