Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-22.1: scripts: adjust bump-pebble.sh to add build/bazelutil/distdir_files.bzl #82840

Merged
merged 1 commit into from
Jun 13, 2022
Merged

release-22.1: scripts: adjust bump-pebble.sh to add build/bazelutil/distdir_files.bzl #82840

merged 1 commit into from
Jun 13, 2022

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Jun 13, 2022 •
edited by jbowens
Loading

Backport 1/1 commits from #82751 on behalf of @jbowens.

/cc @cockroachdb/release

The bump-pebble.sh script should git add build/bazelutil/distdir_files.bzl
which requires updates whenever the Pebble version is bumped.

Release note: None

Release justification: Non-production code changes.

@jbowens
scripts: adjust bump-pebble.sh to add build/bazelutil/distdir_files.bzl
4a0007f 
The bump-pebble.sh script should `git add build/bazelutil/distdir_files.bzl`
which requires updates whenever the Pebble version is bumped.

Release note: None
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.1-82751 branch from e4d5188 to 4a0007f Compare June 13, 2022 18:52
@blathers-crl blathers-crl bot requested review from jbowens, nicktrav and a team June 13, 2022 18:52
@blathers-crl
Copy link
Author

blathers-crl bot commented Jun 13, 2022 •
edited by jbowens
Loading

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Jun 13, 2022
@cockroach-teamcity
Copy link
Member

This change is Reviewable

nicktrav
nicktrav approved these changes Jun 13, 2022
View reviewed changes
Copy link
Collaborator

@nicktrav nicktrav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @jbowens)

@jbowens jbowens merged commit 34d3248 into release-22.1 Jun 13, 2022
@jbowens jbowens deleted the blathers/backport-release-22.1-82751 branch June 13, 2022 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbowens jbowens jbowens approved these changes

@nicktrav nicktrav nicktrav approved these changes

Assignees

@jbowens jbowens

Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cockroach-teamcity @nicktrav @jbowens