Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.1: ttljob: make TTL work for multi-tenant #82711

Merged
merged 1 commit into from
Jun 10, 2022

Conversation

otan
Copy link
Contributor

@otan otan commented Jun 10, 2022

Backport 1/1 commits from #82390.

/cc @cockroachdb/release


Use the appropriate KV abstraction to make ttl work for serverless
clusters.

We can't use SPLIT AT with multi-tenant tests, so we are skipping
those for now.

Release note (sql change): The cluster setting
sql.ttl.range_batch_size is deprecated.

Resolves #82386

Release note (sql change): Row-level TTL now works for multi-tenant
clusters.

Release justification: bug for for new feat on serverless

Use the appropriate KV abstraction to make ttl work for serverless
clusters.

We can't use `SPLIT AT` with multi-tenant tests, so we are skipping
those for now.

Release note (sql change): The cluster setting
`sql.ttl.range_batch_size` is deprecated.

Release note (sql change): Row-level TTL now works for multi-tenant
clusters.
@otan otan requested a review from rafiss June 10, 2022 10:11
@otan otan requested a review from a team as a code owner June 10, 2022 10:11
@otan otan requested a review from a team June 10, 2022 10:11
@blathers-crl
Copy link

blathers-crl bot commented Jun 10, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@otan otan merged commit 3181b7f into cockroachdb:release-22.1 Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants