build: require go1.12 #38379
build: require go1.12 #38379
Conversation
|
This change is |
andreimatei
force-pushed
the
small.go-112
branch
2 times, most recently
from
a16da8a to
521a52d
Compare
|
Some more tweaks. |
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @andreimatei and @petermattis)
build/teamcity-assert-clean.sh, line 13 at r1 (raw file):
git diff -a >&2 || true echo "Nuking build cruft. Please teach this build to clean up after itself." >&2 run docker run --volume="$root:/nuke" --workdir="/nuke" golang:stretch /bin/bash -c "git clean -ffdx ; git submodule foreach --recursive git clean -xffd" >&2
This will automatically use 1.13 when that's released, no? Is that desirable?
There was a problem hiding this comment.
Reviewable status:
build/teamcity-assert-clean.sh, line 13 at r1 (raw file):
Previously, RaduBerinde wrote…
This will automatically use 1.13 when that's released, no? Is that desirable?
I thought so... To be honest I don't understand what this docker invocation does; how does it use go?
There was a problem hiding this comment.
Reviewable status:
build/teamcity-assert-clean.sh, line 13 at r1 (raw file):
Previously, andreimatei (Andrei Matei) wrote…
I thought so... To be honest I don't understand what this docker invocation does; how does it use go?
I guess it's just a random image that has git in it. Now the question is why does it use docker... Jordan says that maybe the system git is too old. 🤷♂️
There was a problem hiding this comment.
Reviewable status:
build/teamcity-assert-clean.sh, line 13 at r1 (raw file):
Previously, andreimatei (Andrei Matei) wrote…
I guess it's just a random image that has git in it. Now the question is why does it use docker... Jordan says that maybe the system git is too old. 🤷♂️
Oh.. I didn't notice it just runs git. Weird.
There is another invocation here:
For that one my question stands. I think we should fix that to 1.12 or things might break when 1.13 gets released.
andreimatei
force-pushed
the
small.go-112
branch
from
521a52d to
4d0ba9b
Compare
Since the builder was upgraded a while ago and we already have code needing 1.12. Some assembly files no longer have any (intended) effect in go 1.12, and their existence has proven surprisingly troublesome as their comments indicated. Closes cockroachdb#35637 Release note: The minimum compiler version for building CRDB is now go 1.12.
andreimatei
force-pushed
the
small.go-112
branch
from
4d0ba9b to
a8b7483
Compare
There was a problem hiding this comment.
Took over #38384 here.
Reviewable status:
build/teamcity-assert-clean.sh, line 13 at r1 (raw file):
Previously, RaduBerinde wrote…
Oh.. I didn't notice it just runs git. Weird.
There is another invocation here:
For that one my question stands. I think we should fix that to 1.12 or things might break when 1.13 gets released.
yup, fixed that one. Thanks.
There was a problem hiding this comment.
bors r+
Reviewable status:
There was a problem hiding this comment.
bors please
bors+
Reviewable status:
There was a problem hiding this comment.
bors r+
Reviewable status:
Build succeeded |
Since the builder was upgraded a while ago and we already have code
needing 1.12.
Release note: The minimum compiler version for building CRDB is now go
1.12.