Address code review feedback #3475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -459,6 +459,11 @@ func (gp golangParameters) Arg(name string) (parser.Datum, bool) { | |||
| if arg == nil { | |||
| return parser.DNull, true | |||
| } | |||
| // TODO: This type switch has been created primarily for convenience, but | |||
| // the fact that multiple integer types are part of the switch is inelegant | |||
| // and prone to errors (it has been described as "whack-a-mole".) There is | |||
There was a problem hiding this comment.
period should come after the closing paren. LGTM
|
LGTM |
Adjusted a type switch case, added a TODO
mrtracy
force-pushed
the
mtracy/code_review_feedback
branch
from
c2c2958
to
a334b6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusted a type switch case, added a TODO