pretty: improve the simplification for binary scalar expressions #27255
+1,013
−199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This change is |
knz
force-pushed
the
20180707-pretty-bin-prec
branch
from
c376f09 to
0313b9d
Compare
This uses the precedence more to simplify binary expressions. Release note: None
knz
force-pushed
the
20180707-pretty-bin-prec
branch
from
0313b9d to
de00899
Compare
madelynnblue
approved these changes
Jul 7, 2018
Contributor
Author
|
Thanks!
bors r+
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
|
craig bot
pushed a commit
that referenced
this pull request
Jul 8, 2018
27255: pretty: improve the simplification for binary scalar expressions r=knz a=knz Noted by @mjibson in #27225 (comment) This uses the precedence more to simplify binary expressions. Release note: None Co-authored-by: Raphael 'kena' Poss <knz@cockroachlabs.com>
Contributor
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noted by @mjibson in #27225 (comment)
This uses the precedence more to simplify binary expressions.
Release note: None