storage: use replica cleanup function in yet another code path #27138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This change is |
nvb
reviewed
Jul 3, 2018
pkg/storage/store.go
Outdated
Contributor
There was a problem hiding this comment.
Don't we need to lock the store mu?
When extracting replica cleanup into a helper function, Store.unlinkReplicaByRangeIDLocked, in d404a3f, I missed this code path. Release note: None
benesch
force-pushed
the
more-unlink-cleanup
branch
from
c14ca96 to
d24eadb
Compare
nvb
approved these changes
Jul 3, 2018
Contributor
Author
|
bors r=nvanbenschoten |
craig bot
pushed a commit
that referenced
this pull request
Jul 3, 2018
27138: storage: use replica cleanup function in yet another code path r=nvanbenschoten a=benesch When extracting replica cleanup into a helper function, Store.unlinkReplicaByRangeIDLocked, in d404a3f, I missed this code path. Release note: None Co-authored-by: Nikhil Benesch <nikhil.benesch@gmail.com>
Contributor
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When extracting replica cleanup into a helper function,
Store.unlinkReplicaByRangeIDLocked, in d404a3f, I missed this code path.
Release note: None