-
Notifications
You must be signed in to change notification settings - Fork 4k
docs: fix the "global matching" regex flag to "g" #27128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the contribution! The build is failing the auto-generated HTML version of these docs, in docs/generated/sql/functions.md, that needs to be updated. If you run --- a/docs/generated/sql/functions.md
+++ b/docs/generated/sql/functions.md
@@ -777,8 +777,12 @@ has no relationship with the commit order of concurrent transactions.</p>
<td>Case-sensitive matching</td>
</tr>
<tr>
+<td><strong>g</strong></td>
+<td>Global matching (match each substring instead of only the first)</td>
+</tr>
+<tr>
<td><strong>i</strong></td>
-<td>Global matching (match each substring instead of only the first).</td>
+<td>Case-insensitive matching</td>
</tr>
<tr>
<td><strong>m</strong> or <strong>n</strong></td>Commit that, amend, and push and we'll be good to go. (You can also hit the "Allow edits from maintainers" checkbox on GitHub to allow us to make the change ourselves.) |
|
@benesch Done. Thanks for the tip! |
|
Thank you! Looks good. One last nit: we like to keep our commit history tidy, so could you squash those two commits into one? (Again, happy to do this on your behalf if you check that box.) |
|
Ok, but why not just Squash and Merge in GitHub? Also, from my end, it looks like the checkbox is checked. |
The global matching flag is "r", not "i". Reinstate "i" as the "case-insensitive" flag.
We use a merge bot, Bors—who'll you'll meet shortly—to prevent merge skew, and Bors doesn't support squashing, unfortunately.
Oh, you're absolutely right. My apologies. I seem to have been pushing to the wrong branch on your remote. I've squashed it now. Thanks again for your contribution, @nexdrew! bors r+ |
Build succeeded |
Also reinstate "i" as the "case-insensitive" flag and preserve alphabetical order of flags in table.
Closes #27107.