opt: refactor lower level of optsteps #27111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This change is |
Contributor
|
Review status: pkg/sql/opt/testutils/custom_opt.go, line 25 at r1 (raw file):
How about Comments from Reviewable |
complete! 0 of 0 LGTMs obtained (and 1 stale)
Extracting the lower level logic around setting up the optimizer for `optsteps` into a new struct. The same low-level functionality will be used to implement a new command focused around exploration transforms. We also fix an edge case in `suppressExprs` (now `restrictToGroup`) - when an expression has multiple children from which the target group is reachable, we were only recursing on the first one. Release note: None
Member
Author
|
Review status: pkg/sql/opt/testutils/custom_opt.go, line 25 at r1 (raw file): Previously, andy-kimball (Andy Kimball) wrote…
I like it! I struggled with the name. I also added some comments. Comments from Reviewable |
Member
Author
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jul 3, 2018
27111: opt: refactor lower level of optsteps r=RaduBerinde a=RaduBerinde Extracting the lower level logic around setting up the optimizer for `optsteps` into a new struct. The same low-level functionality will be used to implement a new command focused around exploration transforms. We also fix an edge case in `suppressExprs` (now `restrictToGroup`) - when an expression has multiple children from which the target group is reachable, we were only recursing on the first one. Release note: None Co-authored-by: Radu Berinde <radu@cockroachlabs.com>
Contributor
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracting the lower level logic around setting up the optimizer for
optstepsinto a new struct. The same low-level functionality will beused to implement a new command focused around exploration transforms.
We also fix an edge case in
suppressExprs(nowrestrictToGroup) -when an expression has multiple children from which the target group
is reachable, we were only recursing on the first one.
Release note: None