sql: lowercase session var name in test #27097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release note: None
Member
|
This change is |
Contributor
|
Review status: Comments from Reviewable |
complete! 0 of 0 LGTMs obtained (and 1 stale)
Contributor
Author
|
TFYR bors r+ |
Contributor
Author
|
bors rekkt bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jul 2, 2018
26605: ui: collect statement stats from all nodes r=couchand a=couchand The initial statement stats API endpoint only exposed the local node's statements. This extends it to query all the other nodes as well, properly aggregates across nodes, and provides the per-node details on the statement details page. <img width="659" alt="screen shot 2018-06-28 at 5 19 00 pm" src="https://user-images.githubusercontent.com/793969/42061214-65fe50bc-7af7-11e8-81f1-839256985e03.png"> 26654: workload: add geo-distributed support to tpccbench r=m-schneider a=m-schneider This patch is adding support for a zones flag which will allow tpccbench to benchmark over geodistributed clusters. Closes #25878 Release note: None 27095: sql: clean up "alter table relocate" r=knz a=knz On the way to address #26840. The RELOCATE action on ALTER TABLE is experimental, i.e. not meant to have a stable API for users, however there is no reason for the code that implements it to mention "testing" or "experimental" other than the grammar and tests. This patch cleans up the code accordingly, removing references of "testing" in the code. In addition the patch cleans up further by ensuring the experimental feature is marked with the "EXPERIMENTAL" keyword instead of "TESTING" throughout the code base and tests. Release note: None 27096: sql: refer to "show ranges" using the "experimental" keyword r=knz a=knz On the way to address #26840. Both the syntax `SHOW TESTING_RANGES` and `SHOW EXPERIMENTAL_RANGES` are recognized, but only the latter is canonical. Ensure it is used throughout. Release note: None 27097: sql: lowercase session var name in test r=knz a=knz Found while working on #26840. Release note: None Co-authored-by: Andrew Couch <andrew@cockroachlabs.com> Co-authored-by: Masha Schneider <masha@cockroachlabs.com> Co-authored-by: Raphael 'kena' Poss <knz@cockroachlabs.com>
Contributor
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found while working on #26840.
Release note: None