storage: use engine for os-level operations. #27075
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This change is |
Contributor
Author
|
At some point, I need to go through all uses of the |
29 tasks
mberhault
force-pushed
the
marc/fix_ingest_with_encryption
branch
2 times, most recently
from
efedcaa to
b1851ba
Compare
bdarnell
reviewed
Jul 5, 2018
Contributor
bdarnell
left a comment
bdarnell
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (and 1 stale)
Contributor
Author
|
bors r+ |
Contributor
Build failed |
This is important when encryption is enabled as we need to make sure we handle file metadata properly. While `os.Remove` will leave cruft behind, `os.Link` won't copy the file encryption settings from the original and will therefore make it unreadable. This fixes `RESTORE` which writes file to local disk using local encryption settings then ingests them. The link bypassed the rocksdb Env leaving the ingested file without any encryption settings attached (aka: plaintext). Release note: None
mberhault
force-pushed
the
marc/fix_ingest_with_encryption
branch
from
b1851ba to
48b5af5
Compare
Contributor
Author
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jul 5, 2018
27075: storage: use engine for os-level operations. r=mberhault a=mberhault This is important when encryption is enabled as we need to make sure we handle file metadata properly. While `os.Remove` will leave cruft behind, `os.Link` won't copy the file encryption settings from the original and will therefore make it unreadable. This fixes `RESTORE` which writes file to local disk using local encryption settings then ingests them. The link bypassed the rocksdb Env leaving the ingested file without any encryption settings attached (aka: plaintext). Release note: None 27087: roachtest: disable encryption on tests that can't handle it. r=mberhault a=mberhault Two cases make encryption always fail: - old versions (<= 2.0) - uses of debug commands that open the rocksdb instance (needs encryption flags) Release note: None Co-authored-by: marc <marc@cockroachlabs.com>
Contributor
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is important when encryption is enabled as we need to make sure we
handle file metadata properly.
While
os.Removewill leave cruft behind,os.Linkwon't copy the fileencryption settings from the original and will therefore make it
unreadable.
This fixes
RESTOREwhich writes file to local disk using localencryption settings then ingests them. The link bypassed the rocksdb Env
leaving the ingested file without any encryption settings attached (aka:
plaintext).
Release note: None