mmaprototype: add more MMA related metrics#162562
Open
5hubh4m wants to merge 1 commit intocockroachdb:masterfrom
Open
mmaprototype: add more MMA related metrics#1625625hubh4m wants to merge 1 commit intocockroachdb:masterfrom
5hubh4m wants to merge 1 commit intocockroachdb:masterfrom
Conversation
Contributor
|
Merging to
|
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
Contributor
Author
Preview of the metrics from a roachprod cluster. We can clearly see disk capacities being incorrectly calculated as <100 MiB on a number of stores. |
5hubh4m
force-pushed
the
mma_more_metrics
branch
from
6dd6842 to
f98b19f
Compare
5hubh4m
requested review from
nameisbhaskar and
shailendra-patel
and removed request for
a team,
nameisbhaskar and
shailendra-patel
5hubh4m
force-pushed
the
mma_more_metrics
branch
from
f98b19f to
5c3491b
Compare
Add load and capacity related metrics to observe exactly what MMA sees instead of having to perform backwards calculations from raw data. Release note: None
5hubh4m
force-pushed
the
mma_more_metrics
branch
from
5c3491b to
8eb6172
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add load and capacity related metrics to observe exactly what MMA sees instead of having to perform backwards calculations from raw data.
Fixes: #158681
Epic: CRDB-56265
Release note: None