Skip to content

release-25.4: revert: deflake TestRevertSpansFanout under race#162549

Open
kev-cao wants to merge 1 commit intocockroachdb:release-25.4from
kev-cao:blathers/backport-release-25.4-162474
Open

release-25.4: revert: deflake TestRevertSpansFanout under race#162549
kev-cao wants to merge 1 commit intocockroachdb:release-25.4from
kev-cao:blathers/backport-release-25.4-162474

Conversation

@kev-cao
Copy link
Contributor

@kev-cao kev-cao commented Feb 5, 2026

Backport 1/1 commits from #162474 on behalf of @kev-cao.


This test spins up a multi-node cluster, which is flaky when under race.

Fixes: #162132

Fixes: #162193

Fixes: #161164

Release note: None


Release justification: Test-only change.

This test spins up a multi-node cluster, which is flaky when under race.

Fixes: cockroachdb#162132

Release note: None
@kev-cao kev-cao requested a review from a team as a code owner February 5, 2026 16:55
@kev-cao kev-cao requested review from andrew-r-thomas and removed request for a team February 5, 2026 16:55
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Feb 5, 2026
@blathers-crl blathers-crl bot requested a review from dt February 5, 2026 16:55
@blathers-crl
Copy link

blathers-crl bot commented Feb 5, 2026

Thanks for opening a backport.

Before merging, please confirm that it falls into one of the following categories (select one):

  • Non-production code changes. Includes test-only changes, build system changes, etc.
  • Fixes for serious issues. Defined in the policy as correctness, stability, or security issues, data corruption/loss, significant performance regressions, breaking working and widely used functionality, or an inability to detect and debug production issues.
  • Other approved changes. These changes must be gated behind a disabled-by-default feature flag unless there is a strong justification not to.

Add a brief release justification to the PR description explaining your selection.

Also, confirm that the change does not break backward compatibility and complies with all aspects of the backport policy.

All backports must be reviewed by the TL and EM for the owning area.

@blathers-crl blathers-crl bot added backport Label PR's that are backports to older release branches T-disaster-recovery labels Feb 5, 2026
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@blathers-crl
Copy link

blathers-crl bot commented Feb 5, 2026

✅ PR #162549 is compliant with backport policy

Confidence: high
Backward compatible: true
Explanation: The pull request is compliant with the backport policy because it contains a 'Release justification: Test-only change' in the PR body, satisfying the exception for changes that only affect non-production code. Additionally, the files changed in this PR are associated with test code. Specifically, the file pkg/revert/revert_test.go is a test file, and changes here indicate modifications to unit tests, including the use of a helper from the testutils package to skip tests when under race conditions. The modification in pkg/revert/BUILD.bazel adds a dependency related to testing utilities, which also falls within the scope of non-production, workflow-related changes.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. T-disaster-recovery

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants