changefeedccl: apply all checkpoints before flushing#162546
Open
jeffswenson wants to merge 1 commit intocockroachdb:masterfrom
Open
changefeedccl: apply all checkpoints before flushing#162546jeffswenson wants to merge 1 commit intocockroachdb:masterfrom
jeffswenson wants to merge 1 commit intocockroachdb:masterfrom
Conversation
Previously, the checkpoint logic lived in side of the per-span loop. This could result in updating a checkpoint O(spans) times when there is a lagging span in the frontier. This has always been slightly sub-optimal, because we may advance the high water mark multiple times while processing spans, but its particularly costly as of 25.4 because we save individual frontier changes. Release note (performance improvement): improved the performance on changefeed checkpoint when changefeeds are lagging. Informs: cockroachdb#158913
Contributor
|
Merging to
|
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
jeffswenson
added
backport-26.1.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the checkpoint logic lived in side of the per-span loop. This could result in updating a checkpoint O(spans) times when there is a lagging span in the frontier. This has always been slightly sub-optimal, because we may advance the high water mark multiple times while processing spans, but its particularly costly as of 25.4 because we save individual frontier changes.
Release note (performance improvement): improved the performance on changefeed checkpoint when changefeeds are lagging. Informs: #158913