Skip to content

[wip] introduce --redact-locally flag in debug zip command#162542

Draft
arjunmahishi wants to merge 1 commit intocockroachdb:release-24.1from
arjunmahishi:redact-locally
Draft

[wip] introduce --redact-locally flag in debug zip command#162542
arjunmahishi wants to merge 1 commit intocockroachdb:release-24.1from
arjunmahishi:redact-locally

Conversation

@arjunmahishi
Copy link
Contributor

No description provided.

@blathers-crl
Copy link

blathers-crl bot commented Feb 5, 2026

⚠️ End-of-Life Version Warning

This backport targets 24.1, which is an End-of-Life (EOL) version.

Please verify that backporting to this EOL version is intentional and appropriate. EOL versions no longer receive maintenance updates according to our support policy.


Thanks for opening a backport.

Before merging, please confirm that it falls into one of the following categories (select one):

  • Non-production code changes. Includes test-only changes, build system changes, etc.
  • Fixes for serious issues. Defined in the policy as correctness, stability, or security issues, data corruption/loss, significant performance regressions, breaking working and widely used functionality, or an inability to detect and debug production issues.
  • Other approved changes. These changes must be gated behind a disabled-by-default feature flag unless there is a strong justification not to.

Add a brief release justification to the PR description explaining your selection.

Also, confirm that the change does not break backward compatibility and complies with all aspects of the backport policy.

All backports must be reviewed by the TL and EM for the owning area.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Feb 5, 2026
@blathers-crl
Copy link

blathers-crl bot commented Feb 5, 2026

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@blathers-crl
Copy link

blathers-crl bot commented Feb 5, 2026

✅ PR #162542 is compliant with backport policy

Confidence: high
Feature flag detected: Yes
Backward compatible: true
Explanation: The pull request introduces a new feature flag '--redact-locally' which enables client-side redaction of log files in the debug zip command. This flag is disabled by default as indicated in the file diffs where the default value for 'redactLocally' is set to false. The changes are localized to CLI components and involve adding new functionality rather than modifying existing, ensuring it does not break backward compatibility. The feature flag satisfies the backport policy compliance as new features or behavior changes are controlled at runtime and can be enabled or disabled as needed.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Label PR's that are backports to older release branches

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants