rpc: add protocol label to rpc connection metrics#162528
Open
suj-krishnan wants to merge 1 commit intocockroachdb:masterfrom
Open
rpc: add protocol label to rpc connection metrics#162528suj-krishnan wants to merge 1 commit intocockroachdb:masterfrom
suj-krishnan wants to merge 1 commit intocockroachdb:masterfrom
Conversation
Epic: CRDB-48931 Fixes: 162513 Release note: None
Member
|
This change is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new label
protocolto peer metrics, where applicable. This will enable us to provide non-disruptive observability to customers for these metrics during gRPC to DRPC migration.During the migration period, when a cluster is expected to have a mix of grpc and drpc traffic, existing customer dashboards and alerts that use these metrics will show an aggregate of grpc and drpc traffic. Customers can drill-down by the
protocollabel, to see the split.For more details, refer to: DRPC migration: Changes to Essential RPC metrics
Epic: CRDB-48931
Fixes: #162513
Release note: None