Skip to content

admission: promote key admission control metrics to Essential#162511

Open
kevin-v-ngo wants to merge 1 commit intocockroachdb:masterfrom
kevin-v-ngo:kevin/promote-ac-metrics-essential
Open

admission: promote key admission control metrics to Essential#162511
kevin-v-ngo wants to merge 1 commit intocockroachdb:masterfrom
kevin-v-ngo:kevin/promote-ac-metrics-essential

Conversation

@kevin-v-ngo
Copy link

Previously, several critical admission control metrics lacked Essential status, making them harder to discover for monitoring and troubleshooting cluster health issues.

This commit promotes 9 admission control metrics to Essential:

  • admission.wait_durations.* (sql-kv-response, sql-sql-response, elastic-stores, elastic-cpu) - latency histograms showing throttling delays
  • admission.granter.*_exhausted_duration.kv (slots, io_tokens, elastic_io_tokens) - duration metrics indicating resource exhaustion
  • admission.elastic_cpu.nanos_exhausted_duration - elastic CPU token exhaustion tracking
  • kvflowcontrol.eval_wait.*.duration - flow token wait times
  • kvflowcontrol.send_queue.bytes - queued raft entry size

Each metric now includes:

  • Visibility: ESSENTIAL for documentation and end user monitoring inclusion
  • Category: OVERLOAD
  • HowToUse: guidance on interpreting values and troubleshooting

Resolves: #162508
Epic: CRDB-35697

Release note (ops change): Promoted 9 admission control metrics to Essential status, making them more discoverable in documentation and downstream dashboards. These metrics track admission control wait times, resource exhaustion (slots, I/O tokens, CPU tokens), and replication flow control, providing critical visibility into cluster health and performance throttling.

@blathers-crl
Copy link

blathers-crl bot commented Feb 5, 2026

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@cockroachlabs-cla-agent
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Kevin Ngo seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Previously, several critical admission control metrics lacked
Essential status, making them harder to discover for monitoring
and troubleshooting cluster health issues.

This commit promotes 9 admission control metrics to Essential:
- admission.wait_durations.* (sql-kv-response, sql-sql-response,
  elastic-stores, elastic-cpu) - latency histograms showing
  throttling delays
- admission.granter.*_exhausted_duration.kv (slots, io_tokens,
  elastic_io_tokens) - duration metrics indicating resource
  exhaustion
- admission.elastic_cpu.nanos_exhausted_duration - elastic CPU
  token exhaustion tracking
- kvflowcontrol.eval_wait.*.duration - flow token wait times
- kvflowcontrol.send_queue.bytes - queued raft entry size

Each metric now includes:
- Visibility: ESSENTIAL for dashboard/monitoring inclusion
- Category: OVERLOAD for resource exhaustion tracking
- HowToUse: guidance on interpreting values and troubleshooting

Resolves: cockroachdb#162508
Epic: CRDB-35697

Release note (ops change): Promoted 9 admission control metrics
to Essential status, making them more discoverable in monitoring
dashboards and troubleshooting workflows. These metrics track
admission control wait times, resource exhaustion (slots, I/O
tokens, CPU tokens), and replication flow control, providing
critical visibility into cluster health and performance throttling.
@kevin-v-ngo kevin-v-ngo force-pushed the kevin/promote-ac-metrics-essential branch from 99a5ef5 to 1793489 Compare February 5, 2026 04:52
@blathers-crl
Copy link

blathers-crl bot commented Feb 5, 2026

Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks.

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@kevin-v-ngo kevin-v-ngo marked this pull request as ready for review February 5, 2026 13:48
@kevin-v-ngo kevin-v-ngo requested a review from a team as a code owner February 5, 2026 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Admission Control: Essential Metrics Classification & Cloud Integration Updates

2 participants