admission: promote key admission control metrics to Essential#162511
Open
kevin-v-ngo wants to merge 1 commit intocockroachdb:masterfrom
Open
admission: promote key admission control metrics to Essential#162511kevin-v-ngo wants to merge 1 commit intocockroachdb:masterfrom
kevin-v-ngo wants to merge 1 commit intocockroachdb:masterfrom
Conversation
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
Kevin Ngo seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Previously, several critical admission control metrics lacked Essential status, making them harder to discover for monitoring and troubleshooting cluster health issues. This commit promotes 9 admission control metrics to Essential: - admission.wait_durations.* (sql-kv-response, sql-sql-response, elastic-stores, elastic-cpu) - latency histograms showing throttling delays - admission.granter.*_exhausted_duration.kv (slots, io_tokens, elastic_io_tokens) - duration metrics indicating resource exhaustion - admission.elastic_cpu.nanos_exhausted_duration - elastic CPU token exhaustion tracking - kvflowcontrol.eval_wait.*.duration - flow token wait times - kvflowcontrol.send_queue.bytes - queued raft entry size Each metric now includes: - Visibility: ESSENTIAL for dashboard/monitoring inclusion - Category: OVERLOAD for resource exhaustion tracking - HowToUse: guidance on interpreting values and troubleshooting Resolves: cockroachdb#162508 Epic: CRDB-35697 Release note (ops change): Promoted 9 admission control metrics to Essential status, making them more discoverable in monitoring dashboards and troubleshooting workflows. These metrics track admission control wait times, resource exhaustion (slots, I/O tokens, CPU tokens), and replication flow control, providing critical visibility into cluster health and performance throttling.
99a5ef5 to
1793489
Compare
|
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, several critical admission control metrics lacked Essential status, making them harder to discover for monitoring and troubleshooting cluster health issues.
This commit promotes 9 admission control metrics to Essential:
Each metric now includes:
Resolves: #162508
Epic: CRDB-35697
Release note (ops change): Promoted 9 admission control metrics to Essential status, making them more discoverable in documentation and downstream dashboards. These metrics track admission control wait times, resource exhaustion (slots, I/O tokens, CPU tokens), and replication flow control, providing critical visibility into cluster health and performance throttling.