sql: add a couple of metrics about SetupFlowRequest RPCs #160673
+44
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
We have a pool of distsql runner workers (proportional to vCPUs per node) that execute SetupFlowRequest RPCs in parallel with the main goroutine of the gateway flow. This commit adds two counters to track number of requests done via those parallel workers as well as sequentially via the main goroutine, which should give us signal whether a cluster needs adjustment of `sql.distsql.num_runners` cluster setting. Release note: None
yuzefovich
force-pushed
the
distsql-runner-metrics
branch
from
accbb84 to
1d2713d
Compare
yuzefovich
added
backport-25.2.x
yuzefovich
requested review from
golgeek and
srosenberg
and removed request for
a team,
golgeek and
srosenberg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a pool of distsql runner workers (proportional to vCPUs per node) that execute SetupFlowRequest RPCs in parallel with the main goroutine of the gateway flow. This commit adds two counters to track number of requests done via those parallel workers as well as sequentially via the main goroutine, which should give us signal whether a cluster needs adjustment of
sql.distsql.num_runnerscluster setting.Epic: None
Release note: None