release-26.1: sqlliveness: prevent expiration regressions for sessions #160669
+109
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds a new test to show the SQL liveness session expiration regression hazard described in cockroachdb#160304 (comment). Informs cockroachdb#160304 Release note: None
This fixes the hazard shown in the previous commit, where intermittent errors when trying to heartbeat a sql liveness session could cause a regression in the session'e expiration time. Closes cockroachdb#160304 Closes cockroachdb#159447 Closes cockroachdb#159812 Closes cockroachdb#159053 Closes cockroachdb#160242 Closes cockroachdb#159991 Closes cockroachdb#157894 Release note: None
arulajmani
force-pushed
the
blathers/backport-release-26.1-160662
branch
from
b706c10 to
7d34c12
Compare
blathers-crl
bot
added
blathers-backport
|
Thanks for opening a backport. Before merging, please confirm that the change does not break backwards compatibility and otherwise complies with the backport policy. Include a brief release justification in the PR description explaining why the backport is appropriate. All backports must be reviewed by the TL for the owning area. While the stricter LTS policy does not yet apply, please exercise judgment and consider gating non-critical changes behind a disabled-by-default feature flag when appropriate. |
blathers-crl
bot
added
backport
Member
|
This change is |
rafiss
approved these changes
Jan 8, 2026
Collaborator
rafiss
left a comment
rafiss
left a comment
There was a problem hiding this comment.
thanks for catching this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 2/2 commits from #160662 on behalf of @arulajmani.
See individual commits for details.
Release justification: fix a bug that can cause a node to shut down suddenly when sqlliveness queries get retried