-
Notifications
You must be signed in to change notification settings - Fork 4.1k
release-24.3: sqlliveness: prevent expiration regressions for sessions #160665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-24.3: sqlliveness: prevent expiration regressions for sessions #160665
Conversation
This patch adds a new test to show the SQL liveness session expiration regression hazard described in cockroachdb#160304 (comment). Informs cockroachdb#160304 Release note: None
This fixes the hazard shown in the previous commit, where intermittent errors when trying to heartbeat a sql liveness session could cause a regression in the session'e expiration time. Closes cockroachdb#160304 Closes cockroachdb#159447 Closes cockroachdb#159812 Closes cockroachdb#159053 Closes cockroachdb#160242 Closes cockroachdb#159991 Closes cockroachdb#157894 Release note: None
b014dd6 to
c22c340
Compare
|
Thanks for opening a backport. Before merging, please confirm that it falls into one of the following categories (select one):
Add a brief release justification to the PR description explaining your selection. Also, confirm that the change does not break backward compatibility and complies with all aspects of the backport policy. All backports must be reviewed by the TL and EM for the owning area. |
|
✅ PR #160665 is compliant with backport policy Confidence: high 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Backport 2/2 commits from #160662 on behalf of @arulajmani.
See individual commits for details.
Release justification: fix a bug that can cause a node to shut down suddenly when sqlliveness queries get retried