Skip to content

Conversation

@arulajmani
Copy link
Collaborator

@arulajmani arulajmani commented Jan 7, 2026

Backport 2/2 commits from #160662 on behalf of @arulajmani.


See individual commits for details.


Release justification: fix a bug that can cause a node to shut down suddenly when sqlliveness queries get retried

This patch adds a new test to show the SQL liveness session expiration
regression hazard described in
cockroachdb#160304 (comment).

Informs cockroachdb#160304

Release note: None
This fixes the hazard shown in the previous commit, where intermittent
errors when trying to heartbeat a sql liveness session could cause a
regression in the session'e expiration time.

Closes cockroachdb#160304
Closes cockroachdb#159447
Closes cockroachdb#159812
Closes cockroachdb#159053
Closes cockroachdb#160242
Closes cockroachdb#159991
Closes cockroachdb#157894

Release note: None
@arulajmani arulajmani force-pushed the blathers/backport-release-24.3-160662 branch from b014dd6 to c22c340 Compare January 7, 2026 23:02
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Jan 7, 2026
@blathers-crl blathers-crl bot requested review from a team, fqazi and stevendanna January 7, 2026 23:02
@blathers-crl
Copy link

blathers-crl bot commented Jan 7, 2026

Thanks for opening a backport.

Before merging, please confirm that it falls into one of the following categories (select one):

  • Non-production code changes. Includes test-only changes, build system changes, etc.
  • Fixes for serious issues. Defined in the policy as correctness, stability, or security issues, data corruption/loss, significant performance regressions, breaking working and widely used functionality, or an inability to detect and debug production issues.
  • Other approved changes. These changes must be gated behind a disabled-by-default feature flag unless there is a strong justification not to.

Add a brief release justification to the PR description explaining your selection.

Also, confirm that the change does not break backward compatibility and complies with all aspects of the backport policy.

All backports must be reviewed by the TL and EM for the owning area.

@blathers-crl blathers-crl bot added backport Label PR's that are backports to older release branches T-db-server labels Jan 7, 2026
@blathers-crl
Copy link

blathers-crl bot commented Jan 7, 2026

✅ PR #160665 is compliant with backport policy

Confidence: high
Critical bug criteria met: [Stability or security issues]
Backward compatible: true
Explanation: This PR addresses the backport policy compliance for backporting changes to the 'release-24.3' branch. Firstly, the PR body includes a 'Release justification: fix a bug that can cause a node to shut down suddenly when sqlliveness queries get retried,' which permits an exemption from the standard backport policy requirements about critical bugs or feature flag gating. Such unexpected shutdowns of nodes are directly related to stability issues, qualifying as a critical bug fix under the provided policy. Furthermore, changes include modifications to non-production files (testing files), which are inherently exempt from critical bug or feature flag requirements. The primary production file changed, 'slinstance.go,' directly relates to the bug being addressed that potentially affects node stability. Finally, the changes are backward compatible as they do not remove any version gates or introduce breaking API changes, focusing primarily on bug fixes without altering existing functionality for users.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@arulajmani arulajmani requested a review from rafiss January 8, 2026 17:57
@arulajmani arulajmani merged commit 1a2e21a into cockroachdb:release-24.3 Jan 8, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. T-db-server target-release-24.3.26

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants