cli: filter standalone NOTICE lines in debug zip test output #158033
Merged
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
Abhinav1299
force-pushed
the
filter-license-notice
branch
from
452cfd8 to
1317273
Compare
Abhinav1299
requested review from
aa-joshi,
arjunmahishi and
kyle-a-wong
and removed request for
a team
aa-joshi
approved these changes
Nov 19, 2025
Contributor
aa-joshi
left a comment
aa-joshi
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @arjunmahishi and @kyle-a-wong)
Potential Bug(s) DetectedThe three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation. Next Steps: Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary. After you review the findings, please tag the issue as follows:
|
github-actions
bot
added
the
o-AI-Review-Potential-Issue-Detected
Remove intermittent license-related NOTICE messages from zip output in tests. Resolves: cockroachdb#157888, cockroachdb#157889 Epic: None Release note: None
Abhinav1299
force-pushed
the
filter-license-notice
branch
from
1317273 to
0e73369
Compare
Contributor
Author
|
TFTR! |
Contributor
Abhinav1299
added
backport-25.4.x
This was referenced Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove intermittent license-related NOTICE messages from zip output in tests.
Resolves: #157888, #157889
Epic: None
Release note: None