release-25.3: sql/schemachanger: improve performance of TestBackupSuccess #154727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we only supported running a closure against a TestServer in the schema changer testing framework. This was problematic for tests that could save time by sharing servers (for example BACKUP / RESTORE). To address this, this patch introduces a Start method for starting up a server. Release note: None
Previously, the successful backup tests would for each stage of a schema change would run the full schema change, taking a backup at the target stage. This patch modifies the TestBackupSuccess variants of the schema changer test to start the server once, take all the backups and then restore the stages we should be testing. Testing show around a ~30% improvement with this change in execution time. Fixes: cockroachdb#152076 Release note: None
fqazi
force-pushed
the
blathers/backport-release-25.3-152112
branch
from
678f0c6 to
f95be21
Compare
blathers-crl
bot
added
blathers-backport
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=95b789b1d594ac6b74f377aa7555d8d98d63240d&v=4){kind=avatar}
|
Thanks for opening a backport. Before merging, please confirm that the change does not break backwards compatibility and otherwise complies with the backport policy. Include a brief release justification in the PR description explaining why the backport is appropriate. All backports must be reviewed by the TL for the owning area. While the stricter LTS policy does not yet apply, please exercise judgment and consider gating non-critical changes behind a disabled-by-default feature flag when appropriate. |
blathers-crl
bot
added
backport
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
rafiss
added
the
backport-test-only
rafiss
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 2/2 commits from #152112 on behalf of @fqazi.
Previously, the successful backup tests would for each stage of a schema
change would run the full schema change, taking a backup at the target
stage. This patch modifies the TestBackupSuccess variants of the schema
changer test to start the server once, take all the backups and then
restore the stages we should be testing.
Testing show around a ~30% improvement with this change in execution
time.
Fixes: #152076
Release note: None
Release justification: test only change