kvserver: dump memFS when TestCheckConsistencyInconsistent fails #151122
Conversation
|
This change is |
stevendanna
left a comment
stevendanna
left a comment
There was a problem hiding this comment.
Overall LGTM. One question that I leave to your discretion.
| dstEntryPath := dstFS.PathJoin(dstPath, entry) | ||
| if err := CopyRecursive(srcFS, dstFS, srcEntryPath, dstEntryPath); err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
Should we fsync() the dstPath here to ensure newly created directory entries are also present?
There was a problem hiding this comment.
A follow-up here, if you do decide the fsync the directory, you might need some error handling since some filesystems return an error when fsyncing a directory.
There was a problem hiding this comment.
Oof, reasonable point, but I think getting into that would be a distraction at this point. I'll go ahead and merge this.
|
stressrace helpfully reproduced the WAL error (ref). I'm going to merge this so that the other failure also gets the artifacts on master if it fails again. TFTR! |
|
This PR was included in a batch that successfully built, but then failed to merge into master (it was a non-fast-forward update). It will be automatically retried. |
celeste-cockroachdb
bot
added
v25.4.0-prerelease
and removed
target-release-25.4.0
labels
3 participants
Informs #150660.
Epic: none