all: remove tenant 2 as an app tenant from tests #148561
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we support tenant id 2 as an application tenant in tests but tenant id 2 doesn't exist in demo cluster and normal operations. Following the migration to UA, tenant 2 would be a system tenant and will no longer serve as an application tenant. Due to this, we are moving the tenant id 2 to tenant id 3. This patch removes any usage of tenant id 2 from tests and also disables the creation of tenants with id 2. Fixes : cockroachdb#138801 Epic : CRDB-45181 Release note : none
|
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
Nukitt
added a commit
to Nukitt/cockroach-go
that referenced
this pull request
Jun 23, 2025
Following the migration to UA, we are not allowing tenantID 2 to be used as an application tenant anymore. Currently testserver creates tenantid 2, but it will fail to do so in the future following the rule to disable tenant id 2 in cockroachdb/cockroach#148561. This change will allow us to start assigning tenantIDs from 3 and pass the failing tests in #148561.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we support tenant id 2 as an application tenant in tests
but tenant id 2 doesn't exist in demo cluster and normal operations.
Following the migration to UA, tenant 2 would be a system
tenant and will no longer serve as an application tenant.
Due to this, we are moving the tenant id 2 to tenant id 3.
This patch removes any usage of tenant id 2 from tests and
also disables the creation of tenants with id 2.
Fixes : #138801
Epic : CRDB-45181
Release note : none