Skip to content

release-24.3: ui: fix index link from sql activity plan details page #147636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kyle-a-wong
Copy link
Contributor

Backport 1/1 commits from #147433 on behalf of @kyle-a-wong.


In cockroach cloud console, the index link from the sql activity plan details page links to a non-existent page, resulting in a redirect to the overview page.

Now, the correct link should be used in cockroach cloud.

Fixes: #136476
Epic: None
Release note: None


Release justification:

In cockroach cloud console, the index link from the
sql activity plan details page links to a non-existent
page, resulting in a redirect to the overview page.

Now, the correct link should be used in cockroach cloud.

Fixes: cockroachdb#136476
Epic: None
Release note: None
@kyle-a-wong kyle-a-wong force-pushed the blathers/backport-release-24.3-147433 branch from 2f1e921 to dab1943 Compare June 2, 2025 17:25
@kyle-a-wong kyle-a-wong requested a review from a team as a code owner June 2, 2025 17:25
@kyle-a-wong kyle-a-wong removed the request for review from a team June 2, 2025 17:25
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Jun 2, 2025
@kyle-a-wong kyle-a-wong requested a review from dhartunian June 2, 2025 17:25
@kyle-a-wong kyle-a-wong added O-robot Originated from a bot. blathers-backport This is a backport that Blathers created automatically. labels Jun 2, 2025
Copy link

blathers-crl bot commented Jun 2, 2025

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Jun 2, 2025
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@kyle-a-wong kyle-a-wong merged commit beb6c85 into cockroachdb:release-24.3 Jun 2, 2025
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. target-release-24.3.15
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants